Bug 167754 - Don't attempt wide gamut on older OSes
Summary: Don't attempt wide gamut on older OSes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-02 13:53 PST by Megan Gardner
Modified: 2017-02-02 15:26 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.95 KB, patch)
2017-02-02 14:16 PST, Megan Gardner 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2017-02-02 13:53:36 PST 
Don't attempt wide gammut on older OSes
Comment 1 Megan Gardner 2017-02-02 14:16:21 PST 
Created attachment 300446 [details]
Patch
Comment 2 Megan Gardner 2017-02-02 14:18:13 PST 
Not sure if we needed the iOS check, but thought I should be more not less thorough.
Comment 3 Tim Horton 2017-02-02 14:44:52 PST 
Comment on attachment 300446 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300446&action=review

> Source/WebKit2/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:65
> +#if (__MAC_OS_X_VERSION_MIN_REQUIRED >= 101200)

No need for the parens.

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:2500
> +#if (__IPHONE_OS_VERSION_MIN_REQUIRED >= 100000)

This matches the extendedSRGBColorSpaceRef() thing, right? Also, no parens.
Comment 4 Megan Gardner 2017-02-02 15:13:44 PST 
Yep, matches. I'll take out parens and commit.
Comment 5 Megan Gardner 2017-02-02 15:26:52 PST 
https://trac.webkit.org/changeset/211601