LayoutTest http/tests/media/track-in-band-hls-metadata-crash.html is a flaky timeout https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fmedia%2Ftrack-in-band-hls-metadata-crash.html
This test was added with https://trac.webkit.org/changeset/211495
This appears to be limited to El Capitan.
Jer, this test continues to be very flaky. Can you take a look?
<rdar://problem/30434020>
Marked test as flaky in https://trac.webkit.org/changeset/211985
Created attachment 309593 [details] Patch
Comment on attachment 309593 [details] Patch Thanks for reviewing!
Comment on attachment 309593 [details] Patch Clearing flags on attachment: 309593 Committed r216588: <http://trac.webkit.org/changeset/216588>
All reviewed patches have been landed. Closing bug.
Reopening to attach new patch.
Created attachment 309700 [details] Patch
Comment on attachment 309700 [details] Patch This is fine if this works, but another way to remove the flakiness of the current version is to not log the 'canplaythrough' event: document.addEventListener('canplaythrough', () => { video.play() });
(In reply to Eric Carlson from comment #12) > Comment on attachment 309700 [details] > Patch > > This is fine if this works, but another way to remove the flakiness of the > current version is to not log the 'canplaythrough' event: > document.addEventListener('canplaythrough', () => { video.play() }); Ah, I see, thanks! I also noticed that the 'canplaythrough' event was dispatched twice on one of the bots, causing 'video.play()' to be called two times.
(In reply to Per Arne Vollan from comment #13) > (In reply to Eric Carlson from comment #12) > > Comment on attachment 309700 [details] > > Patch > > > > This is fine if this works, but another way to remove the flakiness of the > > current version is to not log the 'canplaythrough' event: > > document.addEventListener('canplaythrough', () => { video.play() }); > > Ah, I see, thanks! I also noticed that the 'canplaythrough' event was > dispatched twice on one of the bots, causing 'video.play()' to be called two > times. document.oncanplaythrough = () => { document.removeAttribute('oncanplaythrough'); video.play() });
Comment on attachment 309700 [details] Patch Clearing flags on attachment: 309700 Committed r216680: <http://trac.webkit.org/changeset/216680>
Created attachment 309890 [details] Patch
(In reply to Eric Carlson from comment #14) > (In reply to Per Arne Vollan from comment #13) > > (In reply to Eric Carlson from comment #12) > > > Comment on attachment 309700 [details] > > > Patch > > > > > > This is fine if this works, but another way to remove the flakiness of the > > > current version is to not log the 'canplaythrough' event: > > > document.addEventListener('canplaythrough', () => { video.play() }); > > > > Ah, I see, thanks! I also noticed that the 'canplaythrough' event was > > dispatched twice on one of the bots, causing 'video.play()' to be called two > > times. > > document.oncanplaythrough = () => { > document.removeAttribute('oncanplaythrough'); video.play() }); Thanks! I have updated the patch :)
Comment on attachment 309890 [details] Patch Clearing flags on attachment: 309890 Committed r216885: <http://trac.webkit.org/changeset/216885>