When the media element is narrow and we can no longer display both the volume button and the fullscreen button, we should switch to a compact mode where the controls bar is shorter and the buttons smaller.
<rdar://problem/29565842>
Created attachment 300422 [details] Patch
Comment on attachment 300422 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300422&action=review > Source/WebCore/Modules/modern-media-controls/controls/macos-compact-inline-media-controls.css:52 > +.media-controls.mac.inline.compact button.fullscreen { > + -webkit-mask-position-y: 6.5px; > +} Won't this be blurry on non-retina devices? > Source/WebCore/Modules/modern-media-controls/controls/macos-compact-inline-media-controls.css:71 > +.media-controls.mac.inline.compact .volume.slider { > + left: -19.5px; > +} Ditto. > Source/WebCore/WebCore.xcodeproj/project.pbxproj:284 > - 07C046C71E425155007201E7 /* AudioTrackPrivateMediaStreamCocoa.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 07C046C51E42512F007201E7 /* AudioTrackPrivateMediaStreamCocoa.cpp */; }; > - 07C046C81E425155007201E7 /* AudioTrackPrivateMediaStreamCocoa.h in Headers */ = {isa = PBXBuildFile; fileRef = 07C046C61E42512F007201E7 /* AudioTrackPrivateMediaStreamCocoa.h */; }; > + 07C046C71E425155007201E7 /* (null) in Sources */ = {isa = PBXBuildFile; }; > + 07C046C81E425155007201E7 /* (null) in Headers */ = {isa = PBXBuildFile; }; What is this? > Source/WebCore/WebCore.xcodeproj/project.pbxproj:-15368 > - 07C046C51E42512F007201E7 /* AudioTrackPrivateMediaStreamCocoa.cpp */, > - 07C046C61E42512F007201E7 /* AudioTrackPrivateMediaStreamCocoa.h */, ?? > Source/WebCore/WebCore.xcodeproj/project.pbxproj:27814 > - 07C046C81E425155007201E7 /* AudioTrackPrivateMediaStreamCocoa.h in Headers */, > + 07C046C81E425155007201E7 /* (null) in Headers */, ?? > Source/WebCore/WebCore.xcodeproj/project.pbxproj:32070 > - 07C046C71E425155007201E7 /* AudioTrackPrivateMediaStreamCocoa.cpp in Sources */, > + 07C046C71E425155007201E7 /* (null) in Sources */, ??
Comment on attachment 300422 [details] Patch Attachment 300422 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2992786 New failing tests: media/modern-media-controls/media-controller/media-controller-toggle-compact-mode.html
Created attachment 300433 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Committed r211590: <http://trac.webkit.org/changeset/211590>