Bug 167731 - [GTK] Add initial implementation of resource usage overlay
Summary: [GTK] Add initial implementation of resource usage overlay
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2017-02-02 06:20 PST by Carlos Garcia Campos
Modified: 2017-02-03 05:05 PST (History)
1 user (show)

See Also:

Attachments
Patch (22.42 KB, patch)
2017-02-02 06:28 PST, Carlos Garcia Campos 		mcatanzaro: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-02-02 06:20:39 PST 
This is quite useful for developers to debug cpu and memory usage as well as GC timers.
Comment 1 Carlos Garcia Campos 2017-02-02 06:28:18 PST 
Created attachment 300406 [details]
Patch
Comment 2 Carlos Garcia Campos 2017-02-02 06:29:48 PST 
You can see a screenshot here:

http://people.igalia.com/cgarcia/mb-resources-overlay.png

This is just an initial version, it doesn't have cool graphs showing the history like the Apple one, but we can add more stuff later.
Comment 3 Michael Catanzaro 2017-02-02 09:54:47 PST 
Comment on attachment 300406 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300406&action=review

> Source/WebCore/PlatformGTK.cmake:66
> +    page/linux/ResourceUsageOverlayLinux.cpp
> +    page/linux/ResourceUsageThreadLinux.cpp

You have to add this in a Linux conditional somewhere... it's not going to work on FreeBSD or Darwin.
Comment 4 Carlos Garcia Campos 2017-02-03 05:05:14 PST 
Committed r211631: <http://trac.webkit.org/changeset/211631>