WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
167719
ScriptDebugServer::sourceParsed takes a long time when running the sampling profiler
https://bugs.webkit.org/show_bug.cgi?id=167719
Summary
ScriptDebugServer::sourceParsed takes a long time when running the sampling p...
Keith Miller
Reported
2017-02-01 17:17:19 PST
I noticed this when running the sampling profiler for C code on JSBench amazon/safari.
Attachments
Add attachment
proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1
2017-02-06 12:15:38 PST
I had a patch a while back that moved this line detection to the parser. However the frontend only treats \n as a newline and the parser treats \r\n and friends, so they differed. I agree this loop entirely through the source is not good and should be eliminated.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug