Bug 167710 - [iOS WK2] With visual viewports, a fixed bottom bar can be clipped out when the keyboard is visible
Summary: [iOS WK2] With visual viewports, a fixed bottom bar can be clipped out when t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-02-01 14:32 PST by Simon Fraser (smfr)
Modified: 2017-02-01 17:15 PST (History)
7 users (show)

See Also:

Attachments
Patch (12.08 KB, patch)
2017-02-01 14:37 PST, Simon Fraser (smfr) 		wenson_hsieh: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2017-02-01 14:32:38 PST 
[iOS WK2] With visual viewports, a fixed bottom bar can be clipped out when the keyboard is visible
Comment 1 Simon Fraser (smfr) 2017-02-01 14:37:32 PST 
Created attachment 300355 [details]
Patch
Comment 2 Simon Fraser (smfr) 2017-02-01 14:37:55 PST 
rdar://problem/30100286
Comment 3 Wenson Hsieh 2017-02-01 15:15:50 PST 
Comment on attachment 300355 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300355&action=review

> Source/WebKit2/ChangeLog:13
> +=

Stray "=" here

> Source/WebKit2/UIProcess/ios/WKContentView.mm:379
> +        CGRect inputViewContentBounds = [self.window convertRect:inputViewBounds toView:self];

Let's address this separately. It looks like this conversion breaks the behavior where fixed inputs dock to the visible content rect accounting for keyboard bounds.
Comment 4 Simon Fraser (smfr) 2017-02-01 17:15:00 PST 
https://trac.webkit.org/r211541