Bug 167687 - The CSS property -webkit-text-stroke is not applied on captions.
Summary: The CSS property -webkit-text-stroke is not applied on captions.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-02-01 04:26 PST by Per Arne Vollan
Modified: 2017-02-03 09:41 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.25 KB, patch)
2017-02-01 04:33 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (4.11 KB, patch)
2017-02-03 05:29 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2017-02-01 04:26:55 PST 
Styling captions with text stroke has no effect on text rendering.
Comment 1 Per Arne Vollan 2017-02-01 04:33:45 PST 
Created attachment 300319 [details]
Patch
Comment 2 Per Arne Vollan 2017-02-01 04:35:06 PST 
<rdar://problem/30305523>
Comment 3 Brent Fulgham 2017-02-01 09:17:16 PST 
Comment on attachment 300319 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300319&action=review

This change looks good, but please create a test case.

> Source/WebCore/ChangeLog:8
> +        Add style to list of valid properties for cue.

This is a simple change, but it seems like a test case would help us avoid this breaking in the future.

Could you please create a LayoutTest for this?
Comment 4 Per Arne Vollan 2017-02-03 05:29:36 PST 
Created attachment 300521 [details]
Patch
Comment 5 Per Arne Vollan 2017-02-03 07:11:33 PST 
(In reply to comment #3)
> Comment on attachment 300319 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=300319&action=review
> 
> This change looks good, but please create a test case.
> 
> > Source/WebCore/ChangeLog:8
> > +        Add style to list of valid properties for cue.
> 
> This is a simple change, but it seems like a test case would help us avoid
> this breaking in the future.
> 
> Could you please create a LayoutTest for this?

Thanks for reviewing :) Updated patch.
Comment 6 Brent Fulgham 2017-02-03 08:43:25 PST 
Comment on attachment 300521 [details]
Patch

Thank you for adding the test! r=me
Comment 7 Brent Fulgham 2017-02-03 09:14:09 PST 
<rdar://problem/17940996>
Comment 8 WebKit Commit Bot 2017-02-03 09:41:01 PST 
Comment on attachment 300521 [details]
Patch

Clearing flags on attachment: 300521

Committed r211637: <http://trac.webkit.org/changeset/211637>
Comment 9 WebKit Commit Bot 2017-02-03 09:41:05 PST 
All reviewed patches have been landed.  Closing bug.