Bug 167685 - Prevent app crash on launch during simctl install workaround
Summary: Prevent app crash on launch during simctl install workaround
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-31 22:03 PST by Ryan Haddad
Modified: 2017-02-06 08:22 PST (History)
6 users (show)

See Also:


Attachments
Patch (2.90 KB, patch)
2017-02-01 09:42 PST, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2017-01-31 22:03:06 PST
Process:               WebKitTestRunnerApp [65737]
Path:                  /Users/USER/Library/Developer/CoreSimulator/Devices/8E0097C9-36CC-461B-9BDA-20343CDD8581/data/Containers/Bundle/Application/4B46E900-4012-4202-9594-5DD4E9BB4833/WebKitTestRunnerApp.app/WebKitTestRunnerApp
Identifier:            WebKitTestRunnerApp
Version:               1.0 (1.0)
Code Type:             X86-64 (Native)
Parent Process:        launchd_sim [64461]
Responsible:           WebKitTestRunnerApp [65737]
User ID:               501

Date/Time:             2017-01-31 20:12:09.987 -0800
OS Version:            Mac OS X 10.11.6 (15G1217)
Report Version:        11
Anonymous UUID:        E33747EB-9308-100E-6D50-D06F1FA8AF4E


Time Awake Since Boot: 1200000 seconds

System Integrity Protection: disabled

Crashed Thread:        0

Exception Type:        EXC_BREAKPOINT (SIGTRAP)
Exception Codes:       0x0000000000000002, 0x0000000000000000
Exception Note:        EXC_CORPSE_NOTIFY

Application Specific Information:
dyld: launch, loading dependent libraries
DYLD_FALLBACK_LIBRARY_PATH=/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator.sdk/usr/lib
DYLD_ROOT_PATH=/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator.sdk
DYLD_FALLBACK_FRAMEWORK_PATH=/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator.sdk/System/Library/Frameworks
DYLD_SHARED_REGION=avoid

Dyld Error Message:
  Library not loaded: @rpath/libWebCoreTestSupport.dylib
  Referenced from: /Users/USER/Library/Developer/CoreSimulator/Devices/8E0097C9-36CC-461B-9BDA-20343CDD8581/data/Containers/Bundle/Application/4B46E900-4012-4202-9594-5DD4E9BB4833/WebKitTestRunnerApp.app/WebKitTestRunnerApp
  Reason: image not found

Binary Images:
       0x103a45000 -        0x103a6aff7 +org.webkit.WebKitTestRunnerApp (1.0 - 1.0) <C1704FD9-3070-3D20-9F90-50955C95B9E1> /Users/USER/Library/Developer/CoreSimulator/Devices/8E0097C9-36CC-461B-9BDA-20343CDD8581/data/Containers/Bundle/Application/4B46E900-4012-4202-9594-5DD4E9BB4833/WebKitTestRunnerApp.app/WebKitTestRunnerApp
       0x103abe000 -        0x103ae6707 +dyld_sim (360.22) <E88E2ED5-7530-36BC-B858-9E0D41A4B85B> /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator.sdk/usr/lib/dyld_sim
    0x7fff6b8cf000 -     0x7fff6b906a47  dyld (360.22) <884763FC-CC0F-31CC-ACC4-75A805CE401D> /usr/lib/dyld
Comment 2 Jonathan Bedard 2017-02-01 08:16:34 PST
That is definitely https://trac.webkit.org/changeset/211457.

If you look at what that change is doing, it attempts to launch an app to check that the app is installed.  These crashes can be ignored, they're real, but they don't matter.  I didn't really think about them.  I'll put up a fix shortly that should get rid of them.
Comment 3 Jonathan Bedard 2017-02-01 09:42:30 PST
Created attachment 300332 [details]
Patch
Comment 4 Daniel Bates 2017-02-03 16:41:12 PST
Comment on attachment 300332 [details]
Patch

OK.
Comment 5 WebKit Commit Bot 2017-02-06 08:22:38 PST
Comment on attachment 300332 [details]
Patch

Clearing flags on attachment: 300332

Committed r211725: <http://trac.webkit.org/changeset/211725>
Comment 6 WebKit Commit Bot 2017-02-06 08:22:42 PST
All reviewed patches have been landed.  Closing bug.