Bug 167684 - ld: warning: instance method '_setAutofilled:' in category conflicts with same method from another category
Summary: ld: warning: instance method '_setAutofilled:' in category conflicts with sam...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-31 21:12 PST by Joseph Pecoraro
Modified: 2017-01-31 21:36 PST (History)
3 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (3.49 KB, patch)
2017-01-31 21:20 PST, Joseph Pecoraro 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-01-31 21:12:08 PST 
When building for iOS I see a linker warning:

ld: warning: instance method '_setAutofilled:' in category from /Build/WebKit.build/Release-iphoneos/WebKitLegacy.build/Objects-normal/arm64/DOMHTML.o conflicts with same method from another category

It looks like the same DOMHTMLInputElement extension appears in two places. Lets unify.
Comment 1 Joseph Pecoraro 2017-01-31 21:20:16 PST 
Created attachment 300298 [details]
[PATCH] Proposed Fix
Comment 2 mitz 2017-01-31 21:26:13 PST 
Comment on attachment 300298 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=300298&action=review

> Source/WebKit/mac/DOM/DOMPrivate.h:103
>  - (BOOL)_isTextField;

You should update the comment above, because this isn’t used by Safari anymore.
Comment 3 Joseph Pecoraro 2017-01-31 21:36:27 PST 
<https://trac.webkit.org/changeset/211468>