Bug 167669 – [WebRTC][WebKit2] Support expanding the sandbox to allow microphone access at process launch

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Brent Fulgham]

Due to <rdar://problem/29448368> we need to expand the sandbox to encompass the microphone hardware at the launch of the WebProcess. Once this radar is fixed, lived switching between allowing and denying microphone state at the Sandbox level will work properly.

This change should be viewed as a temporary workaround until the underlying bug is fixed. We do not want to limit microphone access granularity to WebProcess launch.

[Brent Fulgham]

<rdar://problem/29974333>

[Brent Fulgham]

Created attachment 300269 [details]
Patch

[Alex Christensen]

Comment on attachment 300269 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300269&action=review

We definitely need this, but don't we also need to call SandboxExtension::create and consume and revoke it?

> Source/WebKit2/UIProcess/WebProcessPool.cpp:579
> +    // FIXME: Remove this and related parameter when <rdar://problem/29448368> is fixed.

I don't think we need this comment.

[Brent Fulgham]

(In reply to comment #3)
> Comment on attachment 300269 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=300269&action=review
> 
> We definitely need this, but don't we also need to call
> SandboxExtension::create and consume and revoke it?

Isn't that handled by the SandboxExtension::consumePermanently(...) call we make in WebProcessCocoa?

SandboxExtension::createHandleForGenericExtension calls into WKSandboxExtensionCreate.

SandboxExtension::consumePermanently calls WKSandboxExtensionConsume and WKSandboxExtensionDestroy internally.

[youenn fablet]

Comment on attachment 300269 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300269&action=review

> Source/WebKit2/UIProcess/WebProcessPool.cpp:578
> +#if ENABLE(WEB_RTC)

This should probably be ENABLE(MEDIA_STREAM) and mediaStreamEnabled()

[Brent Fulgham]

Created attachment 300285 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 300285 [details]
Patch

Clearing flags on attachment: 300285

Committed r211470: <http://trac.webkit.org/changeset/211470>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.