Bug 167667 - Make DumpRenderTree not crash
Summary: Make DumpRenderTree not crash
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-31 14:32 PST by Megan Gardner
Modified: 2017-01-31 20:30 PST (History)
3 users (show)

See Also:

Attachments
Patch (2.43 KB, patch)
2017-01-31 14:35 PST, Megan Gardner 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2017-01-31 14:32:45 PST 
Make Dump Render Tree not crash
Comment 1 Megan Gardner 2017-01-31 14:35:15 PST 
Created attachment 300262 [details]
Patch
Comment 2 Megan Gardner 2017-01-31 14:35:49 PST 
<rdar://problem/29929387>
Comment 3 Simon Fraser (smfr) 2017-01-31 14:45:15 PST 
Comment on attachment 300262 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300262&action=review

> Tools/ChangeLog:7
> +        DumpRenderTree is crashing when running WK2 tests that it's not supposed to be running. 
> +        So we're making sure it can do that without crashing. The tests won't work, but we won't crash.

It would be nice if you explained the crash. Something like "We were using RunLoop::main().dispatch(), but this crashed because initBlah was never called so the global foo pointer was null.
Comment 4 Tim Horton 2017-01-31 14:52:09 PST 
Comment on attachment 300262 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300262&action=review

> Tools/DumpRenderTree/TestRunner.cpp:47
> +#if PLATFORM(IOS)

This should be in its own block at the bottom of the includes, not here.
Comment 5 Megan Gardner 2017-01-31 17:06:06 PST 
Fixed the windows error.
Comment 6 Megan Gardner 2017-01-31 17:07:46 PST 
https://trac.webkit.org/changeset/211460
Comment 7 Alexey Proskuryakov 2017-01-31 20:30:08 PST 
Comment on attachment 300262 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300262&action=review

> Tools/DumpRenderTree/TestRunner.cpp:2414
> +#if !PLATFORM(IOS)

We normally prefer to have iOS codego first.