RESOLVED FIXED167667
Make DumpRenderTree not crash 
https://bugs.webkit.org/show_bug.cgi?id=167667
Summary Make DumpRenderTree not crash
Megan Gardner
Reported 2017-01-31 14:32:45 PST
Make Dump Render Tree not crash
Attachments
Patch (2.43 KB, patch)
2017-01-31 14:35 PST, Megan Gardner 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2017-01-31 14:35:15 PST
Created attachment 300262 [details] Patch
Megan Gardner
Comment 2 2017-01-31 14:35:49 PST
<rdar://problem/29929387>
Simon Fraser (smfr)
Comment 3 2017-01-31 14:45:15 PST
Comment on attachment 300262 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300262&action=review > Tools/ChangeLog:7 > + DumpRenderTree is crashing when running WK2 tests that it's not supposed to be running. > + So we're making sure it can do that without crashing. The tests won't work, but we won't crash. It would be nice if you explained the crash. Something like "We were using RunLoop::main().dispatch(), but this crashed because initBlah was never called so the global foo pointer was null.
Tim Horton
Comment 4 2017-01-31 14:52:09 PST
Comment on attachment 300262 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300262&action=review > Tools/DumpRenderTree/TestRunner.cpp:47 > +#if PLATFORM(IOS) This should be in its own block at the bottom of the includes, not here.
Megan Gardner
Comment 5 2017-01-31 17:06:06 PST
Fixed the windows error.
Megan Gardner
Comment 6 2017-01-31 17:07:46 PST
https://trac.webkit.org/changeset/211460
Alexey Proskuryakov
Comment 7 2017-01-31 20:30:08 PST
Comment on attachment 300262 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300262&action=review > Tools/DumpRenderTree/TestRunner.cpp:2414 > +#if !PLATFORM(IOS) We normally prefer to have iOS codego first.
Note You need to log in before you can comment on or make changes to this bug.