Bug 167651 - Web Inspector: User Settings: Secondary-clicking the New Tab and Settings tabs should not produce a context menu
Summary: Web Inspector: User Settings: Secondary-clicking the New Tab and Settings tab...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-01-31 10:18 PST by BJ Burg
Modified: 2017-01-31 13:05 PST (History)
5 users (show)

See Also:

Attachments
Patch (5.54 KB, patch)
2017-01-31 11:08 PST, Devin Rousso 		joepeck: review+
Details | Formatted Diff | Diff
Patch (5.22 KB, patch)
2017-01-31 12:28 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2017-01-31 10:18:55 PST 
Via Nelson Thachuk:

* SUMMARY
- Secondary-clicking the New Tab and Settings tabs should not produce a context menu

* STEPS TO REPRODUCE
1. Launch Safari
2. Navigate to a webpage
3. Show Web Inspector (⌥⌘I)
4. Secondary-click the New Tab and Settings buttons

* EXPECTED RESULTS
- Nothing should occur

* ACTUAL RESULTS
- Context menu with “Copy Image” that doesn’t copy anything to the clipboard
Comment 1 BJ Burg 2017-01-31 10:19:19 PST 
<rdar://problem/30222495>
Comment 2 Devin Rousso 2017-01-31 11:08:03 PST 
Created attachment 300237 [details]
Patch
Comment 3 Joseph Pecoraro 2017-01-31 11:13:27 PST 
Comment on attachment 300237 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300237&action=review

> Source/WebInspectorUI/UserInterface/Views/TabBar.js:376
> +    get newTabTabBarItem() { return this._newTabTabBarItem; }

Getters like these should be at the top of the Public section.
Comment 4 Joseph Pecoraro 2017-01-31 11:15:47 PST 
Comment on attachment 300237 [details]
Patch

r=me
Comment 5 Devin Rousso 2017-01-31 12:28:29 PST 
Created attachment 300246 [details]
Patch
Comment 6 WebKit Commit Bot 2017-01-31 13:05:52 PST 
Comment on attachment 300246 [details]
Patch

Clearing flags on attachment: 300246

Committed r211445: <http://trac.webkit.org/changeset/211445>
Comment 7 WebKit Commit Bot 2017-01-31 13:05:55 PST 
All reviewed patches have been landed.  Closing bug.