RESOLVED FIXED 167647
Align [[OwnPropertyKeys]] with the HTML specification for cross-origin Window / Location objects 
https://bugs.webkit.org/show_bug.cgi?id=167647
Summary Align [[OwnPropertyKeys]] with the HTML specification for cross-origin Window...
Chris Dumez
Reported 2017-01-31 09:26:28 PST
Object.getOwnPropertyNames() should return indexed property indices / named property named for cross-origin windows: - https://html.spec.whatwg.org/#crossoriginproperties-(-o-) (Step 4)
Attachments
Patch (13.13 KB, patch)
2017-01-31 09:40 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (13.24 KB, patch)
2017-01-31 09:43 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews103 for mac-elcapitan (892.49 KB, application/zip)
2017-01-31 10:45 PST, Build Bot 		no flags
Details
Patch (15.73 KB, patch)
2017-01-31 10:54 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
WIP Patch (20.17 KB, patch)
2017-02-06 13:44 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (21.59 KB, patch)
2017-02-06 14:23 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-01-31 09:40:52 PST
Created attachment 300225 [details] Patch
Chris Dumez
Comment 2 2017-01-31 09:43:40 PST
Created attachment 300227 [details] Patch
Build Bot
Comment 3 2017-01-31 10:45:19 PST
Comment on attachment 300227 [details] Patch Attachment 300227 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2980299 New failing tests: js/dom/getOwnPropertyDescriptor.html
Build Bot
Comment 4 2017-01-31 10:45:22 PST
Created attachment 300233 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Chris Dumez
Comment 5 2017-01-31 10:54:25 PST
Created attachment 300234 [details] Patch
Chris Dumez
Comment 6 2017-02-02 12:38:15 PST
Object.getOwnPropertyNames() output is incomplete for cross-origin Window: https://html.spec.whatwg.org/#windowproxy-ownpropertykeys We're missing: 1. Indices of subframes 2. Names of subframes 3. The following symbols: @@toStringTag, @@hasInstance, @@isConcatSpreadable
Chris Dumez
Comment 7 2017-02-02 12:39:53 PST
Waiting for https://github.com/w3c/web-platform-tests/pull/4690 to land upstream as the current tests we have are wrong / incomplete.
Radar WebKit Bug Importer
Comment 8 2017-02-02 16:14:10 PST
<rdar://problem/30339489>
Chris Dumez
Comment 9 2017-02-06 13:44:28 PST
Created attachment 300754 [details] WIP Patch
Chris Dumez
Comment 10 2017-02-06 14:23:06 PST
Created attachment 300757 [details] Patch
Sam Weinig
Comment 12 2017-02-06 15:25:14 PST
Comment on attachment 300757 [details] Patch v.nice.
WebKit Commit Bot
Comment 13 2017-02-06 15:52:10 PST
Comment on attachment 300757 [details] Patch Clearing flags on attachment: 300757 Committed r211756: <http://trac.webkit.org/changeset/211756>
WebKit Commit Bot
Comment 14 2017-02-06 15:52:17 PST
All reviewed patches have been landed. Closing bug.
Sam Weinig
Comment 15 2017-02-06 15:53:34 PST
Those are some unfortunate anchor names, given how linkifiers work :(.
Note You need to log in before you can comment on or make changes to this bug.