Bug 167647 - Align [[OwnPropertyKeys]] with the HTML specification for cross-origin Window / Location objects
Summary: Align [[OwnPropertyKeys]] with the HTML specification for cross-origin Window...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://html.spec.whatwg.org/#windowp...
Keywords: InRadar, WebExposed
Depends on: 167881
Blocks:
  Show dependency tree / graph
 
Reported: 2017-01-31 09:26 PST by Chris Dumez
Modified: 2017-02-06 15:53 PST (History)
10 users (show)

See Also:

Attachments
Patch (13.13 KB, patch)
2017-01-31 09:40 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (13.24 KB, patch)
2017-01-31 09:43 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-elcapitan (892.49 KB, application/zip)
2017-01-31 10:45 PST, Build Bot 		no flags Details
Patch (15.73 KB, patch)
2017-01-31 10:54 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
WIP Patch (20.17 KB, patch)
2017-02-06 13:44 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (21.59 KB, patch)
2017-02-06 14:23 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-01-31 09:26:28 PST 
Object.getOwnPropertyNames() should return indexed property indices / named property named for cross-origin windows:
- https://html.spec.whatwg.org/#crossoriginproperties-(-o-) (Step 4)
Comment 1 Chris Dumez 2017-01-31 09:40:52 PST 
Created attachment 300225 [details]
Patch
Comment 2 Chris Dumez 2017-01-31 09:43:40 PST 
Created attachment 300227 [details]
Patch
Comment 3 Build Bot 2017-01-31 10:45:19 PST 
Comment on attachment 300227 [details]
Patch

Attachment 300227 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2980299

New failing tests:
js/dom/getOwnPropertyDescriptor.html
Comment 4 Build Bot 2017-01-31 10:45:22 PST 
Created attachment 300233 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 5 Chris Dumez 2017-01-31 10:54:25 PST 
Created attachment 300234 [details]
Patch
Comment 6 Chris Dumez 2017-02-02 12:38:15 PST 
Object.getOwnPropertyNames() output is incomplete for cross-origin Window:
https://html.spec.whatwg.org/#windowproxy-ownpropertykeys

We're missing:
1. Indices of subframes
2. Names of subframes
3. The following symbols: @@toStringTag, @@hasInstance, @@isConcatSpreadable
Comment 7 Chris Dumez 2017-02-02 12:39:53 PST 
Waiting for https://github.com/w3c/web-platform-tests/pull/4690 to land upstream as the current tests we have are wrong / incomplete.
Comment 8 Radar WebKit Bug Importer 2017-02-02 16:14:10 PST 
<rdar://problem/30339489>
Comment 9 Chris Dumez 2017-02-06 13:44:28 PST 
Created attachment 300754 [details]
WIP Patch
Comment 10 Chris Dumez 2017-02-06 14:23:06 PST 
Created attachment 300757 [details]
Patch
Comment 12 Sam Weinig 2017-02-06 15:25:14 PST 
Comment on attachment 300757 [details]
Patch

v.nice.
Comment 13 WebKit Commit Bot 2017-02-06 15:52:10 PST 
Comment on attachment 300757 [details]
Patch

Clearing flags on attachment: 300757

Committed r211756: <http://trac.webkit.org/changeset/211756>
Comment 14 WebKit Commit Bot 2017-02-06 15:52:17 PST 
All reviewed patches have been landed.  Closing bug.
Comment 15 Sam Weinig 2017-02-06 15:53:34 PST 
Those are some unfortunate anchor names, given how linkifiers work :(.