Bug 167633 – Performance Timeline: Prepare for Worker support

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Joseph Pecoraro]

Summary:
Performance Timeline: Prepare for Worker support

Remove Document / Frame references in Performance.

We will move to ScriptExecutionContext to support Document/WorkerGlobalScope.

And Performance can be given a timeOrigin value instead of looking it up through the Document.

[Joseph Pecoraro]

Created attachment 300193 [details]
[PATCH] Proposed Fix

[WebKit Commit Bot]

Attachment 300193 [details] did not pass style-queue:


ERROR: Source/WebCore/page/PerformanceUserTiming.cpp:120:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Joseph Pecoraro]

Created attachment 300195 [details]
[PATCH] Proposed Fix

I'm 0 for 2 on merge conflicts today! Lets try this one.

[WebKit Commit Bot]

Attachment 300195 [details] did not pass style-queue:


ERROR: Source/WebCore/page/PerformanceUserTiming.cpp:120:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 300195 [details]
[PATCH] Proposed Fix

Attachment 300195 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2978790

New failing tests:
css3/filters/backdrop/dynamic-with-clip-path.html

[Build Bot]

Created attachment 300201 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Joseph Pecoraro]

Comment on attachment 300201 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

> New failing tests:
> css3/filters/backdrop/dynamic-with-clip-path.html

This failure is unrelated.

[Joseph Pecoraro]

Ping for reviewers! This blocks the next patch which is adding Performance APIs to Workers.

[Ryosuke Niwa]

Comment on attachment 300195 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=300195&action=review

> Source/WebCore/page/Performance.cpp:91
> +

Please assert that we're in the main thread here.

[Joseph Pecoraro]

Created attachment 300351 [details]
[PATCH] For Bots

[WebKit Commit Bot]

Attachment 300351 [details] did not pass style-queue:


ERROR: Source/WebCore/page/PerformanceUserTiming.cpp:120:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Joseph Pecoraro]

<https://trac.webkit.org/changeset/211527>