Bug 167620 – REGRESSION (r211379): [ios-simulator] LayoutTest compositing/geometry/fixed-in-composited.html is failing

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ryan Haddad]

[ios-simulator] LayoutTest compositing/geometry/fixed-in-composited.html is failing

https://build.webkit.org/results/Apple%20iOS%2010%20Simulator%20Release%20WK2%20(Tests)/r211394%20(3289)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=compositing%2Fgeometry%2Ffixed-in-composited.html

--- /Volumes/Data/slave/ios-simulator-10-release-tests-wk2/build/layout-test-results/compositing/geometry/fixed-in-composited-expected.txt
+++ /Volumes/Data/slave/ios-simulator-10-release-tests-wk2/build/layout-test-results/compositing/geometry/fixed-in-composited-actual.txt
@@ -16,7 +16,7 @@
   RenderBlock {DIV} at (0,0) size 60x60 [bgcolor=#0000FF33]
 layer at (95,145) size 50x50
   RenderBlock (positioned) zI: 1 {DIV} at (95,145) size 50x50
-layer at (70,70) size 100x100
+layer at (20,70) size 100x100
   RenderBlock (positioned) {DIV} at (20,20) size 100x100 [bgcolor=#008000]
 layer at (200,100) size 50x50
   RenderBlock (positioned) zI: 1 {DIV} at (200,100) size 50x50

[Ryan Haddad]

Flakiness dashboard blames https://trac.webkit.org/changeset/211379

[Simon Fraser (smfr)]

Thanks, I'll look.

[Radar WebKit Bug Importer]

<rdar://problem/30309207>

[Ryan Haddad]

Marked test as failing in http://trac.webkit.org/projects/webkit/changeset/211489

[Simon Fraser (smfr)]

https://trac.webkit.org/changeset/211523

[Ryan Haddad]

(In reply to comment #5)
> https://trac.webkit.org/changeset/211523

This appears to have caused the test to fail on macOS. Does it need a rebaseline?

https://build.webkit.org/results/Apple%20El%20Capitan%20Release%20WK1%20(Tests)/r211523%20(13312)/results.html

--- /Volumes/Data/slave/elcapitan-release-tests-wk1/build/layout-test-results/compositing/geometry/fixed-in-composited-expected.txt
+++ /Volumes/Data/slave/elcapitan-release-tests-wk1/build/layout-test-results/compositing/geometry/fixed-in-composited-actual.txt
@@ -1,8 +1,8 @@
-layer at (0,0) size 785x1000
+layer at (0,0) size 785x2000
   RenderView at (0,0) size 785x600
-layer at (0,0) size 785x1000
-  RenderBlock {HTML} at (0,0) size 785x1000
-    RenderBody {BODY} at (0,0) size 785x1000
+layer at (0,0) size 785x2000
+  RenderBlock {HTML} at (0,0) size 785x2000
+    RenderBody {BODY} at (0,0) size 785x2000
       RenderBlock {P} at (0,210) size 785x18
         RenderText {#text} at (0,0) size 188x18
           text run at (0,0) width 188: "You should see no red above."

[Simon Fraser (smfr)]

Yes, that's just the document size changing.

[Ryan Haddad]

(In reply to comment #7)
> Yes, that's just the document size changing.

Done in https://trac.webkit.org/changeset/211534