Bug 167615 – NULL-deref crash in TextTrack::removeCue()

• Status: REOPENED
• Component: New Bugs

[Jer Noble]

NULL-deref crash in TextTrack::removeCue()

[Jer Noble]

rdar://problem/30106362

[Jer Noble]

Created attachment 300159 [details]
Patch

[Eric Carlson]

Caused by changes for bug 166635.

[WebKit Commit Bot]

Comment on attachment 300159 [details]
Patch

Clearing flags on attachment: 300159

Committed r211401: <http://trac.webkit.org/changeset/211401>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

Can this be tested with a regression test?

[Jer Noble]

Reopening to attach new patch.

[Jer Noble]

Created attachment 300258 [details]
Patch

[Eric Carlson]

Comment on attachment 300258 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300258&action=review

> LayoutTests/http/tests/media/track-in-band-hls-metadata-crash.html:21
> +
> +

Nit: extra blank line.

> LayoutTests/http/tests/media/track-in-band-hls-metadata-crash.html:22
> +            function cuechange() {

Nit: brace on the next line (or change the other functions to match this).

> LayoutTests/http/tests/media/track-in-band-hls-metadata-crash.html:41
> +        <img id=photo>

Nit: this element isn't used.

> LayoutTests/http/tests/media/track-in-band-hls-metadata-crash.html:42
> +        <p>Test for metadata tracks from Apple HLS stream.</p>

Nit: might as well update this comment.

[Jer Noble]

Created attachment 300259 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 300259 [details]
Patch for landing

Rejecting attachment 300259 [details] from commit-queue.

New failing tests:
http/tests/media/track-in-band-hls-metadata-crash.html
Full output: http://webkit-queues.webkit.org/results/2981523

[WebKit Commit Bot]

Created attachment 300270 [details]
Archive of layout-test-results from webkit-cq-01 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-01  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 300259 [details]
Patch for landing

Attachment 300259 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2981541

New failing tests:
http/tests/media/track-in-band-hls-metadata-crash.html

[Build Bot]

Created attachment 300276 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 300259 [details]
Patch for landing

Attachment 300259 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2981601

New failing tests:
http/tests/media/track-in-band-hls-metadata-crash.html

[Build Bot]

Created attachment 300277 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Jer Noble]

Created attachment 300334 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 300334 [details]
Patch for landing

Clearing flags on attachment: 300334

Committed r211495: <http://trac.webkit.org/changeset/211495>