Bug 167609 - [QuickLook] QLPreviewConverter and QuickLookHandle have different lifetime requirements
Summary: [QuickLook] QLPreviewConverter and QuickLookHandle have different lifetime re...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-30 15:11 PST by Andy Estes
Modified: 2017-01-30 17:55 PST (History)
11 users (show)

See Also:

Attachments
Patch (36.67 KB, patch)
2017-01-30 15:34 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2017-01-30 15:11:21 PST 
[QuickLook] QLPreviewConverter and QuickLookHandle have different lifetime requirements
Comment 1 Andy Estes 2017-01-30 15:34:23 PST 
Created attachment 300151 [details]
Patch
Comment 2 WebKit Commit Bot 2017-01-30 15:36:44 PST 
Attachment 300151 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/network/ios/PreviewConverter.mm:51:  Missing spaces around :  [whitespace/init] [4]
ERROR: Source/WebCore/platform/network/ios/PreviewConverter.mm:56:  Missing spaces around :  [whitespace/init] [4]
ERROR: Source/WebCore/loader/ios/QuickLook.mm:327:  Missing spaces around :  [whitespace/init] [4]
ERROR: Source/WebCore/loader/ios/QuickLook.mm:352:  Extra space in capture list.  [whitespace/brackets] [4]
Total errors found: 4 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2017-01-30 17:28:54 PST 
Comment on attachment 300151 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2017-01-30 17:55:26 PST 
Comment on attachment 300151 [details]
Patch

Clearing flags on attachment: 300151

Committed r211398: <http://trac.webkit.org/changeset/211398>
Comment 5 WebKit Commit Bot 2017-01-30 17:55:31 PST 
All reviewed patches have been landed.  Closing bug.