RESOLVED FIXED 167609
[QuickLook] QLPreviewConverter and QuickLookHandle have different lifetime requirements 
https://bugs.webkit.org/show_bug.cgi?id=167609
Summary [QuickLook] QLPreviewConverter and QuickLookHandle have different lifetime re...
Andy Estes
Reported 2017-01-30 15:11:21 PST
[QuickLook] QLPreviewConverter and QuickLookHandle have different lifetime requirements
Attachments
Patch (36.67 KB, patch)
2017-01-30 15:34 PST, Andy Estes 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2017-01-30 15:34:23 PST
Created attachment 300151 [details] Patch
WebKit Commit Bot
Comment 2 2017-01-30 15:36:44 PST
Attachment 300151 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/ios/PreviewConverter.mm:51: Missing spaces around : [whitespace/init] [4] ERROR: Source/WebCore/platform/network/ios/PreviewConverter.mm:56: Missing spaces around : [whitespace/init] [4] ERROR: Source/WebCore/loader/ios/QuickLook.mm:327: Missing spaces around : [whitespace/init] [4] ERROR: Source/WebCore/loader/ios/QuickLook.mm:352: Extra space in capture list. [whitespace/brackets] [4] Total errors found: 4 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 3 2017-01-30 17:28:54 PST
Comment on attachment 300151 [details] Patch r=me
WebKit Commit Bot
Comment 4 2017-01-30 17:55:26 PST
Comment on attachment 300151 [details] Patch Clearing flags on attachment: 300151 Committed r211398: <http://trac.webkit.org/changeset/211398>
WebKit Commit Bot
Comment 5 2017-01-30 17:55:31 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.