Bug 167603 - Drop legacy Attributes.isId attribute
Summary: Drop legacy Attributes.isId attribute
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: WebExposed
Depends on:
Blocks:
 
Reported: 2017-01-30 13:59 PST by Chris Dumez
Modified: 2017-01-30 18:38 PST (History)
11 users (show)

See Also:


Attachments
Patch (16.59 KB, patch)
2017-01-30 14:38 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-01-30 13:59:50 PST
Drop legacy Attributes.isId attribute.

This attribute is not in the specification:
- https://dom.spec.whatwg.org/#interface-attr

Both Firefox and Chrome currently do not expose this attribute.
Comment 1 Chris Dumez 2017-01-30 14:38:07 PST
Created attachment 300144 [details]
Patch
Comment 2 WebKit Commit Bot 2017-01-30 16:23:51 PST
Comment on attachment 300144 [details]
Patch

Clearing flags on attachment: 300144

Committed r211395: <http://trac.webkit.org/changeset/211395>
Comment 3 WebKit Commit Bot 2017-01-30 16:23:57 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Daniel Bates 2017-01-30 18:10:36 PST
Comment on attachment 300144 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300144&action=review

> LayoutTests/dom/xhtml/level3/core/attrisid04.xhtml:-28
> -        xsi:schemaLocation="http://www.w3.org/1999/xhtml hc_staff.xsd"><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/><title>hc_staff</title><script type="text/javascript" src="selfxhtml.js"/><script charset="UTF-8" type="text/javascript" src="attrisid04.js"/><script type='text/javascript'>function loadComplete() { startTest(); }</script></head><body onload="loadComplete()">

Can we remove file LayoutTests/dom/xhtml/level3/core/attrisid04.js?

> LayoutTests/dom/xhtml/level3/core/attrisid05.xhtml:-28
> -        xsi:schemaLocation="http://www.w3.org/1999/xhtml hc_staff.xsd"><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/><title>hc_staff</title><script type="text/javascript" src="selfxhtml.js"/><script charset="UTF-8" type="text/javascript" src="attrisid05.js"/><script type='text/javascript'>function loadComplete() { startTest(); }</script></head><body onload="loadComplete()">

Can we remove file LayoutTests/dom/xhtml/level3/core/attrisid05.js?
Comment 5 Chris Dumez 2017-01-30 18:38:32 PST
(In reply to comment #4)
> Comment on attachment 300144 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=300144&action=review
> 
> > LayoutTests/dom/xhtml/level3/core/attrisid04.xhtml:-28
> > -        xsi:schemaLocation="http://www.w3.org/1999/xhtml hc_staff.xsd"><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/><title>hc_staff</title><script type="text/javascript" src="selfxhtml.js"/><script charset="UTF-8" type="text/javascript" src="attrisid04.js"/><script type='text/javascript'>function loadComplete() { startTest(); }</script></head><body onload="loadComplete()">
> 
> Can we remove file LayoutTests/dom/xhtml/level3/core/attrisid04.js?
> 
> > LayoutTests/dom/xhtml/level3/core/attrisid05.xhtml:-28
> > -        xsi:schemaLocation="http://www.w3.org/1999/xhtml hc_staff.xsd"><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8"/><title>hc_staff</title><script type="text/javascript" src="selfxhtml.js"/><script charset="UTF-8" type="text/javascript" src="attrisid05.js"/><script type='text/javascript'>function loadComplete() { startTest(); }</script></head><body onload="loadComplete()">
> 
> Can we remove file LayoutTests/dom/xhtml/level3/core/attrisid05.js?

Done in <http://trac.webkit.org/changeset/211400>. Thanks.