Bug 167601 - JSDOMBinding is too big. Split it up!
Summary: JSDOMBinding is too big. Split it up!
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-30 13:23 PST by Sam Weinig
Modified: 2017-02-01 03:09 PST (History)
5 users (show)

See Also:

Attachments
Patch (700.03 KB, patch)
2017-01-30 13:31 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (701.77 KB, patch)
2017-01-30 15:41 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (702.85 KB, patch)
2017-01-30 16:13 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (723.88 KB, patch)
2017-01-30 17:26 PST, Sam Weinig 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2017-01-30 13:23:12 PST 
JSDOMBinding is too big. Split it up!
Comment 1 Sam Weinig 2017-01-30 13:31:52 PST 
Created attachment 300138 [details]
Patch
Comment 2 WebKit Commit Bot 2017-01-30 13:34:53 PST 
Attachment 300138 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/js/JSDOMBindingSecurity.h:44:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/bindings/js/JSDOMWrapperCache.h:184:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebCore/bindings/js/JSDOMWrapperCache.h:195:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 3 in 45 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2017-01-30 15:41:43 PST 
Created attachment 300154 [details]
Patch
Comment 4 WebKit Commit Bot 2017-01-30 15:43:52 PST 
Attachment 300154 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/js/JSDOMBindingSecurity.h:44:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/bindings/js/JSDOMWrapperCache.h:184:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebCore/bindings/js/JSDOMWrapperCache.h:195:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 3 in 47 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Sam Weinig 2017-01-30 16:13:48 PST 
Created attachment 300156 [details]
Patch
Comment 6 WebKit Commit Bot 2017-01-30 16:16:40 PST 
Attachment 300156 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/js/JSDOMBindingSecurity.h:44:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/bindings/js/JSDOMWrapperCache.h:184:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebCore/bindings/js/JSDOMWrapperCache.h:195:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 3 in 49 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Sam Weinig 2017-01-30 17:26:06 PST 
Created attachment 300166 [details]
Patch
Comment 8 WebKit Commit Bot 2017-01-30 17:27:30 PST 
Attachment 300166 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/js/JSDOMWrapperCache.h:184:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebCore/bindings/js/JSDOMWrapperCache.h:195:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 2 in 80 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 Sam Weinig 2017-01-30 19:38:58 PST 
Committed r211403: <http://trac.webkit.org/changeset/211403>
Comment 10 Joseph Pecoraro 2017-01-30 22:24:59 PST 
Awesome!
Comment 11 Csaba Osztrogonác 2017-01-31 02:33:58 PST 
(In reply to comment #9)
> Committed r211403: <http://trac.webkit.org/changeset/211403>

It broke the Apple Mac cmake build, see https://build.webkit.org/builders/Apple%20El%20Capitan%20CMake%20Debug%20%28Build%29/builds/11660 for details.
Comment 12 Csaba Osztrogonác 2017-02-01 03:09:08 PST 
buildfix landed in https://trac.webkit.org/changeset/211476