Bug 167598 - Clean up accessibility & animations tests to stop calling testRunner.waitUntilDone() twice
Summary: Clean up accessibility & animations tests to stop calling testRunner.waitUnti...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Safari 10
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
Depends on:
Blocks: 156133
  Show dependency treegraph
Reported: 2017-01-30 11:10 PST by David Kilzer (:ddkilzer)
Modified: 2017-02-02 10:56 PST (History)
12 users (show)

See Also:

Patch v1 (24.85 KB, patch)
2017-01-30 11:47 PST, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2017-01-30 11:10:48 PST
The patch for Bug 156133 shows that testRunner.waitUntilDone() is called multiple times when running some of the tests in LayoutTests/accessibility and LayoutTests/animations.

While calling waitUntilDone() twice in a row doesn't cause any issues in practice, it prevents the patch in Bug 156133 from landing, which would enforce more correct test behavior (and hopefully prevent flaky tests from landing in the tree in the future).
Comment 1 David Kilzer (:ddkilzer) 2017-01-30 11:47:34 PST
Created attachment 300131 [details]
Patch v1
Comment 2 Alexey Proskuryakov 2017-01-30 11:50:48 PST
Comment on attachment 300131 [details]
Patch v1

rs=me pending EWS
Comment 3 WebKit Commit Bot 2017-02-02 10:56:50 PST
Comment on attachment 300131 [details]
Patch v1

Clearing flags on attachment: 300131

Committed r211573: <http://trac.webkit.org/changeset/211573>
Comment 4 WebKit Commit Bot 2017-02-02 10:56:57 PST
All reviewed patches have been landed.  Closing bug.