Bug 167590 – RTCPeerConnection methods can take dictionaries as input

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[youenn fablet]

Currently they take objects.
This is the case for setLocalDescription, setRemoteDescription, addIceCandidate

[youenn fablet]

Created attachment 300115 [details]
Patch

[Build Bot]

Comment on attachment 300115 [details]
Patch

Attachment 300115 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2974509

New failing tests:
fast/mediastream/RTCPeerConnection-js-built-ins-check-this.html

[Build Bot]

Created attachment 300120 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Sam Weinig]

Comment on attachment 300115 [details]
Patch

It seems really unfortunate that all this has to be written manually. Can this be converted to use WebIDL where you would be able to get this for free?

[youenn fablet]

Ideally, we would like to remove the callback legacy API.

If the callback legacy API was removed, the binding generator should do (and does probably already) handle that.

I prefer doing this handling in JS than adding the complexity in the binding generator.
It would be easier to remove it in the future if we can.

[youenn fablet]

Created attachment 300163 [details]
Patch

[Alex Christensen]

Comment on attachment 300163 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300163&action=review

> Source/WebCore/Modules/mediastream/RTCPeerConnectionInternals.js:78
> +        else if (objectInfo.maybeDictionary) {

What if this condition is false?

[youenn fablet]

Comment on attachment 300163 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300163&action=review

>> Source/WebCore/Modules/mediastream/RTCPeerConnectionInternals.js:78
>> +        else if (objectInfo.maybeDictionary) {
> 
> What if this condition is false?

Then objectArgOk is false and we reject the promise.

[WebKit Commit Bot]

Comment on attachment 300163 [details]
Patch

Rejecting attachment 300163 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 300163, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
hing file LayoutTests/fast/mediastream/RTCPeerConnection-setRemoteDescription-offer-expected.txt
patching file LayoutTests/fast/mediastream/RTCPeerConnection-setRemoteDescription-offer.html
patching file LayoutTests/webrtc/rtcpeerconnection-error-messages-expected.txt
patching file LayoutTests/webrtc/rtcpeerconnection-error-messages.html

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Alex Christensen']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/2979940

[youenn fablet]

Created attachment 300223 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 300223 [details]
Patch for landing

Clearing flags on attachment: 300223

Committed r211436: <http://trac.webkit.org/changeset/211436>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.