Bug 167584 – Allow to use stored credentials also for downloads started by DownloadManager::startDownload

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Garcia Campos]

I don't know why this is the default in other ports, but I don't think it's what we want in GTK+.

[Carlos Garcia Campos]

Created attachment 300100 [details]
Patch

[Michael Catanzaro]

Comment on attachment 300100 [details]
Patch

r=me but please ask Alex Christensen before landing if you can do this cross-platform. Either this must be broken on Mac too, or he might have a different suggestion.

[Carlos Garcia Campos]

(In reply to comment #2)
> Comment on attachment 300100 [details]
> Patch
> 
> r=me but please ask Alex Christensen before landing if you can do this
> cross-platform. Either this must be broken on Mac too, or he might have a
> different suggestion.

Alex? :-)

[Alex Christensen]

Comment on attachment 300100 [details]
Patch

This should definitely have a test.  If we allow stored credentials in an ephemeral session, won't it just use the credentials in the CredentialStorage for that session?

[Carlos Garcia Campos]

(In reply to comment #4)
> Comment on attachment 300100 [details]
> Patch
> 
> This should definitely have a test.  If we allow stored credentials in an
> ephemeral session, won't it just use the credentials in the
> CredentialStorage for that session?

But we don't allow it. The patch allows stored credentials only for the default session, the problem is that PendingDownload is created with the default parameter for allow stored credentials unconditionally, which is to no allow them.

[Michael Catanzaro]

So this is good then...?

[Alex Christensen]

Comment on attachment 300100 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=300100&action=review

> Source/WebKit2/NetworkProcess/Downloads/DownloadManager.cpp:64
> +#if PLATFORM(GTK)
> +    // The GTK+ port wants to allow using stored credentials also for pending downloads.
> +    parameters.allowStoredCredentials = sessionID.isEphemeral() ? DoNotAllowStoredCredentials : AllowStoredCredentials;
> +#endif

Let's make this the case on all ports.

[Carlos Garcia Campos]

Committed r212291: <http://trac.webkit.org/changeset/212291>