Now that Safari 10.1 is shipping CSS Grid Layout it seems safe to enable the feature by default: https://developer.apple.com/library/prerelease/content/releasenotes/General/WhatsNewInSafari/Articles/Safari_10_1.html
Created attachment 300092 [details] Patch
Comment on attachment 300092 [details] Patch \o/ But you forgot a part: Source/WebKit2/UIProcess/gtk/ExperimentalFeatures.[h,cpp]. You have to remove CSS grid layout from the settings array as well, since it's no longer experimental. But then we would have no more experimental features covered by this file, so it makes sense to remove the entire file. You could do this in a separate patch, but we should land them at the same time. I wanted to remove it anyway because it needs to be rewritten to use the enumerable experimental features API, so it covers all experimental features instead of just being one more place they have to be hardcoded, and I don't think it makes sense to keep it around in the meantime.
(In reply to comment #2) > But you forgot a part: > Source/WebKit2/UIProcess/gtk/ExperimentalFeatures.[h,cpp]. You have to > remove CSS grid layout from the settings array as well, since it's no longer > experimental. But then we would have no more experimental features covered > by this file, so it makes sense to remove the entire file. You could do this > in a separate patch, but we should land them at the same time. I wanted to > remove it anyway because it needs to be rewritten to use the enumerable > experimental features API, so it covers all experimental features instead of > just being one more place they have to be hardcoded, and I don't think it > makes sense to keep it around in the meantime. True, let's do it in a different patch: bug #167586
Thanks for the review. I'll give some time to other people to comment on this. Otherwise I'll land it tomorrow.
Comment on attachment 300092 [details] Patch Clearing flags on attachment: 300092 Committed r211415: <http://trac.webkit.org/changeset/211415>
All reviewed patches have been landed. Closing bug.