RESOLVED FIXED 167568
Web Inspector: sibling elements's disclosure triangles aren't vertically aligned in DOM tree outline in certain ports 
https://bugs.webkit.org/show_bug.cgi?id=167568
Summary Web Inspector: sibling elements's disclosure triangles aren't vertically alig...
Fujii Hironori
Reported 2017-01-29 18:36:39 PST
Created attachment 300079 [details] screen shot of GTK port In the screenshot, four div elements are sibling, but aren't vertically aligned.
Attachments
screen shot of GTK port (86.77 KB, image/png)
2017-01-29 18:36 PST, Fujii Hironori 		no flags
Details
screen shot of Qt port (61.19 KB, image/png)
2017-01-29 18:41 PST, Fujii Hironori 		no flags
Details
Patch (1.48 KB, patch)
2017-01-29 19:01 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
screen shot of GTK port after the fix (88.22 KB, image/png)
2017-01-29 19:02 PST, Fujii Hironori 		no flags
Details
Patch (1.53 KB, patch)
2017-01-31 17:54 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2017-01-29 18:41:26 PST
Created attachment 300080 [details] screen shot of Qt port Qt port also has the same problem.
Fujii Hironori
Comment 2 2017-01-29 19:01:24 PST
Created attachment 300081 [details] Patch I created a proposed patch. But I'm not confident that this is a right fix.
Fujii Hironori
Comment 3 2017-01-29 19:02:25 PST
Created attachment 300082 [details] screen shot of GTK port after the fix
Devin Rousso
Comment 4 2017-01-29 23:20:33 PST
From what I can tell, this appears to cause no issues with macOS Safari.
Blaze Burg
Comment 5 2017-01-31 07:37:32 PST
Comment on attachment 300081 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=300081&action=review r=me Please fix spelling issues in ChangeLog prior to landing. > Source/WebInspectorUI/ChangeLog:8 > + the tringle has 13px height and has float:left. If the line-height 'The triangle' > Source/WebInspectorUI/ChangeLog:13 > + (.tree-outline.dom li.parent): Set line-height 13px explicitly 'explicitly.'
Fujii Hironori
Comment 6 2017-01-31 17:54:14 PST
Created attachment 300289 [details] Patch Thank you for reviewing my patch. I revised the patch.
WebKit Commit Bot
Comment 7 2017-02-06 03:17:06 PST
Comment on attachment 300289 [details] Patch Clearing flags on attachment: 300289 Committed r211720: <http://trac.webkit.org/changeset/211720>
WebKit Commit Bot
Comment 8 2017-02-06 03:17:10 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.