Bug 167565 – [iOS] Expose WebCore::DataDetection::detectContentInRange WKWebProcessPlugInRangeHandle

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit API

A bundle API client requires the ability to “linkify” a range. Patch forthcoming.

Created attachment 300075 [details]
Add -[WKWebProcessPlugInRangeHandle detectDataWithTypes:context:]

[WebKit Commit Bot]

Attachment 300075 [details] did not pass style-queue:


ERROR: Source/WebKit2/Shared/API/Cocoa/WKDataDetectorTypes.h:46:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Comment on attachment 300075 [details]
Add -[WKWebProcessPlugInRangeHandle detectDataWithTypes:context:]

View in context: https://bugs.webkit.org/attachment.cgi?id=300075&action=review

> Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInRangeHandle.h:46
> +#if TARGET_OS_IPHONE
> +- (NSArray *)detectDataWithTypes:(WKDataDetectorTypes)types context:(NSDictionary *)context WK_API_AVAILABLE(ios(WK_IOS_TBA));
> +#endif

Given that the underlying DataDetection::detectContentInRange() is cross platform, can we make this cross-platform as well?

(In reply to comment #3)
> Comment on attachment 300075 [details]
> Add -[WKWebProcessPlugInRangeHandle detectDataWithTypes:context:]
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=300075&action=review
> 
> > Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInRangeHandle.h:46
> > +#if TARGET_OS_IPHONE
> > +- (NSArray *)detectDataWithTypes:(WKDataDetectorTypes)types context:(NSDictionary *)context WK_API_AVAILABLE(ios(WK_IOS_TBA));
> > +#endif
> 
> Given that the underlying DataDetection::detectContentInRange() is cross
> platform, can we make this cross-platform as well?

Thanks for the review, Sam! On macOS, DataDetection::detectContentInRange() has a degenerate implementation that returns nil. I am afraid that it would just be misleading to expose it via the WebKit API.

Committed <https://trac.webkit.org/r211354>.

[Sam Weinig]

(In reply to comment #4)
> (In reply to comment #3)
> > Comment on attachment 300075 [details]
> > Add -[WKWebProcessPlugInRangeHandle detectDataWithTypes:context:]
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=300075&action=review
> > 
> > > Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInRangeHandle.h:46
> > > +#if TARGET_OS_IPHONE
> > > +- (NSArray *)detectDataWithTypes:(WKDataDetectorTypes)types context:(NSDictionary *)context WK_API_AVAILABLE(ios(WK_IOS_TBA));
> > > +#endif
> > 
> > Given that the underlying DataDetection::detectContentInRange() is cross
> > platform, can we make this cross-platform as well?
> 
> Thanks for the review, Sam! On macOS, DataDetection::detectContentInRange()
> has a degenerate implementation that returns nil. I am afraid that it would
> just be misleading to expose it via the WebKit API.

Indeed!