Bug 167564 - Web content process crashes when initiating a drag on a very large image
Summary: Web content process crashes when initiating a drag on a very large image
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-01-29 12:10 PST by Wenson Hsieh
Modified: 2017-01-30 11:18 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.76 KB, patch)
2017-01-29 12:17 PST, Wenson Hsieh
no flags Details | Formatted Diff | Diff
Patch for landing (1.73 KB, patch)
2017-01-30 10:23 PST, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2017-01-29 12:10:21 PST
If we begin dragging an image element that is too large to show the cached image for, we will show an image file icon instead of the cached image. This is not implemented for all platforms yet.
Comment 1 Wenson Hsieh 2017-01-29 12:17:53 PST
Created attachment 300073 [details]
Patch
Comment 2 Wenson Hsieh 2017-01-30 09:54:15 PST
Comment on attachment 300073 [details]
Patch

Thanks Beth!
Comment 3 WebKit Commit Bot 2017-01-30 10:20:14 PST
Comment on attachment 300073 [details]
Patch

Rejecting attachment 300073 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 300073, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
fs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 211371 = d13624011bbd2af423b2a61b2587178dd8fb05f6
r211372 = fb2141a40b8f0d272cd1c2cbdb0f8965de71d205
r211373 = 9880d8363cb10cae322490f1a56532144562ed60
r211374 = f0a82f8ebc177ca88f6e4cee1455296580873100
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.webkit.org/results/2974626
Comment 4 Wenson Hsieh 2017-01-30 10:23:06 PST
Created attachment 300121 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2017-01-30 11:00:59 PST
Comment on attachment 300121 [details]
Patch for landing

Clearing flags on attachment: 300121

Committed r211377: <http://trac.webkit.org/changeset/211377>
Comment 6 WebKit Commit Bot 2017-01-30 11:01:03 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Wenson Hsieh 2017-01-30 11:18:42 PST
<rdar://problem/30267849>