Bug 167558 - AX: enable search predication for iOS
Summary: AX: enable search predication for iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: chris fleizach
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-01-29 01:25 PST by chris fleizach
Modified: 2017-01-31 00:09 PST (History)
9 users (show)

See Also:

Attachments
patch (34.70 KB, patch)
2017-01-30 12:20 PST, chris fleizach 		no flags Details | Formatted Diff | Diff
patch (58.92 KB, patch)
2017-01-30 12:21 PST, chris fleizach 		no flags Details | Formatted Diff | Diff
patch (58.97 KB, patch)
2017-01-30 12:24 PST, chris fleizach 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2017-01-29 01:25:11 PST 
The searching mechanism we use on macOS should be available on iOS
Comment 1 Radar WebKit Bug Importer 2017-01-29 01:25:26 PST 
<rdar://problem/30251367>
Comment 2 chris fleizach 2017-01-30 12:20:58 PST 
Created attachment 300132 [details]
patch
Comment 3 chris fleizach 2017-01-30 12:21:48 PST 
Created attachment 300133 [details]
patch
Comment 4 WebKit Commit Bot 2017-01-30 12:22:51 PST 
Attachment 300133 [details] did not pass style-queue:


ERROR: Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:74:  An else should appear on the same line as the preceding }  [whitespace/newline] [4]
ERROR: Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:51:  The parameter name "context" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.h:34:  Bad include order. Mixing system and custom headers.  [build/include_order] [4]
ERROR: Tools/DumpRenderTree/mac/AccessibilityCommonMac.h:49:  The parameter name "context" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Tools/DumpRenderTree/mac/AccessibilityCommonMac.mm:72:  An else should appear on the same line as the preceding }  [whitespace/newline] [4]
Total errors found: 5 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 chris fleizach 2017-01-30 12:24:56 PST 
Created attachment 300134 [details]
patch
Comment 6 WebKit Commit Bot 2017-01-31 00:09:13 PST 
Comment on attachment 300134 [details]
patch

Clearing flags on attachment: 300134

Committed r211411: <http://trac.webkit.org/changeset/211411>
Comment 7 WebKit Commit Bot 2017-01-31 00:09:17 PST 
All reviewed patches have been landed.  Closing bug.