Update DiagnosticLoggingClient::logDiagnosticMessageWithValue() to take in the value as a double instead of a string. The value needs to be numeric and the current API is error-prone.
Created attachment 299992 [details] Patch
Comment on attachment 299992 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=299992&action=review > Source/WebCore/loader/EmptyClients.cpp:119 > + void logDiagnosticMessageWithValue(const String&, const String&, double value, unsigned significantFigures, ShouldSample) final { UNUSED_PARAM(value); UNUSED_PARAM(significantFigures); } I like to use commented out names rather than UNUSED_PARAM in cases like this. But also, in EmptyClients.cpp, no need for the names at all. > Source/WebKit2/UIProcess/WebPageProxy.h:165 > +enum class ShouldSample; We normally would put each type of identifier in a separate paragraph rather than putting enum class inside a list of structs.
Created attachment 300119 [details] Patch
Comment on attachment 300119 [details] Patch Clearing flags on attachment: 300119 Committed r211376: <http://trac.webkit.org/changeset/211376>
All reviewed patches have been landed. Closing bug.