RESOLVED FIXED 167535
[Cocoa] No way to get the text from a WKWebProcessPlugInRangeHandle 
https://bugs.webkit.org/show_bug.cgi?id=167535
Summary [Cocoa] No way to get the text from a WKWebProcessPlugInRangeHandle
mitz
Reported 2017-01-27 16:25:17 PST
WKWebProcessPlugInRangeHandle doesn’t expose any way to get at the result of Range::text.
Attachments
Add a text property to WKWebProcessPlugInRangeHandle (3.73 KB, patch)
2017-01-27 18:03 PST, mitz 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2017-01-27 18:03:18 PST
Created attachment 299988 [details] Add a text property to WKWebProcessPlugInRangeHandle
Sam Weinig
Comment 2 2017-01-27 20:36:44 PST
Comment on attachment 299988 [details] Add a text property to WKWebProcessPlugInRangeHandle View in context: https://bugs.webkit.org/attachment.cgi?id=299988&action=review > Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInRangeHandle.h:41 > +@property (nonatomic, readonly) NSString *text WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA)); Do we usually make NSString getter's copy?
mitz
Comment 3 2017-01-27 20:43:05 PST
(In reply to comment #2) > Comment on attachment 299988 [details] > Add a text property to WKWebProcessPlugInRangeHandle > > View in context: > https://bugs.webkit.org/attachment.cgi?id=299988&action=review > > > Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInRangeHandle.h:41 > > +@property (nonatomic, readonly) NSString *text WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA)); > > Do we usually make NSString getter's copy? Yes, I’ll make this one copy as well. Thanks for the review!
mitz
Comment 4 2017-01-27 20:52:20 PST
Fixed in <https://trac.webkit.org/r211321>.
Note You need to log in before you can comment on or make changes to this bug.