Bug 167522 - JSCustomElementInterface::invokeCallback can be called with a null callback because Weak<>
Summary: JSCustomElementInterface::invokeCallback can be called with a null callback b...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-01-27 11:58 PST by Filip Pizlo
Modified: 2017-01-27 16:04 PST (History)
2 users (show)

See Also:

Attachments
the patch (1.56 KB, patch)
2017-01-27 12:02 PST, Filip Pizlo 		msaboff: review-
Details | Formatted Diff | Diff
Patch (3.33 KB, patch)
2017-01-27 14:04 PST, Michael Saboff 		fpizlo: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2017-01-27 11:58:33 PST 
Patch forthcoming.
Comment 1 Filip Pizlo 2017-01-27 12:02:33 PST 
Created attachment 299949 [details]
the patch
Comment 2 Filip Pizlo 2017-01-27 12:02:56 PST 
Ryosuke: I doubt this is the right fix.  Do you know what's going on here?
Comment 3 Michael Saboff 2017-01-27 13:43:39 PST 
I talked with Ryosuke and have a fix that he agrees with.
Comment 4 Michael Saboff 2017-01-27 13:55:19 PST 
<rdar://problem/30240378>
Comment 5 Michael Saboff 2017-01-27 14:04:39 PST 
Created attachment 299958 [details]
Patch
Comment 6 Michael Saboff 2017-01-27 16:04:55 PST 
Committed r211309: <http://trac.webkit.org/changeset/211309>