RESOLVED FIXED 167519
Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line
https://bugs.webkit.org/show_bug.cgi?id=167519
Summary Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line
Joseph Pecoraro
Reported 2017-01-27 11:25:44 PST
Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line This is ugly and annoying!
Attachments
[PATCH] Proposed Fix (3.31 KB, patch)
2017-01-27 11:40 PST, Joseph Pecoraro
rniwa: review+
Joseph Pecoraro
Comment 1 2017-01-27 11:40:36 PST
Created attachment 299947 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 2 2017-01-27 11:44:27 PST
Comment on attachment 299947 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=299947&action=review > Tools/QueueStatusServer/templates/statusbubble.html:57 > + var parentContainer = bubbleContainer.parentElement; Please note that I had no way of testing this code with any fake bugzilla instance. I just paused here in inspector and did these operations to ensure they worked for me. If someone has a way to test this for real, please let me know!
Alexey Proskuryakov
Comment 3 2017-01-27 13:57:01 PST
This is surprising, why do they wrap for you, but not for me? Pretty sure I fixed something like this in the past. Could you add a screenshot? Longer term, we'll be adding more bubbles, so they will no longer fit in a reasonably sized window.
Alexey Proskuryakov
Comment 4 2017-01-27 18:51:17 PST
Comment on attachment 299947 [details] [PATCH] Proposed Fix Now that I'm back at a Mac, I see that it actually wraps for me too. But is there enough space to let it grow horizontally indeed? The layout gets really weird if I make the frame 1000px wide on my 13" MacBook Pro. Even the current 450px looks bad on an iPhone. I agree that the review bar needs it layout to be improved.
Ryosuke Niwa
Comment 5 2017-01-27 22:53:41 PST
Comment on attachment 299947 [details] [PATCH] Proposed Fix Talked in person.
Ryosuke Niwa
Comment 6 2017-01-27 22:54:34 PST
(In reply to comment #4) > Comment on attachment 299947 [details] > [PATCH] Proposed Fix > > Now that I'm back at a Mac, I see that it actually wraps for me too. But is > there enough space to let it grow horizontally indeed? The layout gets > really weird if I make the frame 1000px wide on my 13" MacBook Pro. Even the > current 450px looks bad on an iPhone. Yeah, I think that's a good long term consideration. For now, increasing the width of the bubbles seems like a good short term solution.
Joseph Pecoraro
Comment 7 2017-01-27 23:57:07 PST
(In reply to comment #4) > Comment on attachment 299947 [details] > [PATCH] Proposed Fix > > Now that I'm back at a Mac, I see that it actually wraps for me too. But is > there enough space to let it grow horizontally indeed? The layout gets > really weird if I make the frame 1000px wide on my 13" MacBook Pro. Even the > current 450px looks bad on an iPhone. The 1000px should only be for measuring. It then gets immediately set back to what it was before.
Joseph Pecoraro
Comment 8 2017-01-28 01:28:17 PST
Note You need to log in before you can comment on or make changes to this bug.