Bug 167517 – [WK2] LayoutTest gamepad/gamepad-visibility-1.html is a flaky failure

• Status: NEW
• Component: New Bugs

[Ryan Haddad]

LayoutTest gamepad/gamepad-visibility-1.html is a flaky failure

https://build.webkit.org/results/Apple%20El%20Capitan%20Release%20WK2%20(Tests)/r211249%20(12641)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#tests=gamepad%2Fgamepad-visibility-1.html

--- /Volumes/Data/slave/elcapitan-release-tests-wk2/build/layout-test-results/gamepad/gamepad-visibility-1-expected.txt
+++ /Volumes/Data/slave/elcapitan-release-tests-wk2/build/layout-test-results/gamepad/gamepad-visibility-1-actual.txt
@@ -1,2 +1,2 @@
-No connect event seen in 20 run loop spins. Yay.
+Connect event seen! Should NOT have been seen

[Ryan Haddad]

This seems to be flaky on El Capitan Release WK2 and is showing up in EWS test runs from time to time.

[Ryan Haddad]

(In reply to comment #1)
> This seems to be flaky on El Capitan Release WK2 and is showing up in EWS
> test runs from time to time.

https://webkit-queues.webkit.org/results/2959229
https://webkit-queues.webkit.org/results/2959260

[Alexey Proskuryakov]

I'm also seeing this fail on EWS, making it slow.

[Ryan Haddad]

Marked test as flaky in http://trac.webkit.org/projects/webkit/changeset/211465

[Joseph Pecoraro]

I was able to reproduce this locally, when I run the test 10 times it typically fails the first time and passes all the rest:

  $ run-webkit-tests --iterations=10 --exit-after-n-failures=1 gamepad/gamepad-visibility-1.html

From the WebContentProcess side I see the gamepadconnected event dispatched via:

(lldb) bt
* thread #1, queue = 'com.apple.main-thread', stop reason = step over
    frame #0: WebCore`WebCore::GamepadManager::makeGamepadVisible(this=0x000000011910eb08, platformGamepad=0x00007fcfd0e05910, navigatorSet=0x000000011910eb18, domWindowSet=0x000000011910eb68) at GamepadManager.cpp:159
    frame #1: WebCore`WebCore::GamepadManager::platformGamepadConnected(this=0x000000011910eb08, platformGamepad=0x00007fcfd0e05910) at GamepadManager.cpp:76
    frame #2: WebKit`WebKit::WebGamepadProvider::gamepadConnected(this=0x000000010f64eb10, gamepadData=0x00007fff542baea8) at WebGamepadProvider.cpp:84
    frame #3: WebKit`WebKit::WebProcess::gamepadConnected(this=0x00007fcfd1006400, gamepadData=0x00007fff542baea8) at WebProcess.cpp:1026
    frame #4: WebKit`void IPC::callMemberFunctionImpl<WebKit::WebProcess, void (WebKit::WebProcess::*)(WebKit::GamepadData const&), std::__1::tuple<WebKit::GamepadData>, 0ul>(object=0x00007fcfd1006400, function=40 70 ee 0e 01 00 00 00 00 00 00 00 00 00 00 00, args=0x00007fff542baea8, (null)=std::__1::index_sequence<0UL> @ 0x00007fff542badd0)(WebKit::GamepadData const&), std::__1::tuple<WebKit::GamepadData>&&, std::__1::integer_sequence<unsigned long, 0ul>) at HandleMessage.h:40

Is there something that should be preventing the platformGamepadConnected here?

[Radar WebKit Bug Importer]

<rdar://problem/30340691>

[Joseph Pecoraro]

Retitling, this is not El Capitan or Release specific.