Bug 167512 - Fix diagnostic logging under loader/
Summary: Fix diagnostic logging under loader/
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-27 10:14 PST by Chris Dumez
Modified: 2017-01-27 13:09 PST (History)
5 users (show)

See Also:

Attachments
Patch (12.31 KB, patch)
2017-01-27 10:16 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-01-27 10:14:50 PST 
Fix diagnostic logging under loader/. We should not be using logDiagnosticLoggingWithValue() without a numeric value.
Comment 1 Chris Dumez 2017-01-27 10:16:44 PST 
Created attachment 299941 [details]
Patch
Comment 2 Alex Christensen 2017-01-27 12:01:50 PST 
Comment on attachment 299941 [details]
Patch

Seriously, make logDiagnosticMessageWithValue take a double
Comment 3 Chris Dumez 2017-01-27 12:11:14 PST 
(In reply to comment #2)
> Comment on attachment 299941 [details]
> Patch
> 
> Seriously, make logDiagnosticMessageWithValue take a double

Yes. I am *first* fixing all the call sites that do not pass a number, *then* I'll fix the API.
Comment 4 Chris Dumez 2017-01-27 13:09:17 PST 
Comment on attachment 299941 [details]
Patch

Clearing flags on attachment: 299941

Committed r211301: <http://trac.webkit.org/changeset/211301>
Comment 5 Chris Dumez 2017-01-27 13:09:21 PST 
All reviewed patches have been landed.  Closing bug.