Bug 167509 – [GTK] Add API to handle the accelerated compositing policy

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Garcia Campos]

Now that we have brought back the on demand mode, we should allow applications to choose the policy, wihtout having to deal with environment variables. Settings also allows to set different policy depending on the web view, so for example evolution could disable AC for the composer, but leave the on demand mode for the email viewer.

[Carlos Garcia Campos]

Created attachment 299940 [details]
Patch

[Michael Catanzaro]

Comment on attachment 299940 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299940&action=review

> Source/WebKit2/ChangeLog:8
> +        Now that we have brought back the on demand mode, we should allow applications to choose the policy, wihtout

wihtout -> without

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:1298
> +     * by using %WEBKIT_HARDWARE_ACCELERATION_POLICY_ALWAYS. And it's also posible to diaable it

diaable -> disable

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:3253
> +    if (changed)
> +        g_object_notify(G_OBJECT(settings), "hardware-acceleration-policy");

It's a bit iffy how to handle this, but I would prefer to check the existing value of our API setting and notify if it changes, to close any possibility of notifying if the API setting doesn't change.

[Carlos Garcia Campos]

Committed r211363: <http://trac.webkit.org/changeset/211363>