Bug 167505 – Extend create_hash_table to specify Intrinsic

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yusuke Suzuki]

Extend create_hash_table to specify Intrinsic

[Yusuke Suzuki]

Created attachment 299935 [details]
Patch

[Mark Lam]

Comment on attachment 299935 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299935&action=review

> Source/JavaScriptCore/create_hash_table:-337
> -        if ($name eq "arrayPrototypeTable") {
> -            $intrinsic = "ArrayPushIntrinsic" if ($key eq "push");
> -            $intrinsic = "ArrayPopIntrinsic" if ($key eq "pop");
> -        }

What about these?  I don't see the code that replaces them.

[Mark Lam]

Comment on attachment 299935 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299935&action=review

>> Source/JavaScriptCore/create_hash_table:-337
>> -        }
> 
> What about these?  I don't see the code that replaces them.

Oh, I think they were never needed in the first place.  Yusuke, can you confirm before landing?  Thanks.

[Yusuke Suzuki]

Comment on attachment 299935 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299935&action=review

Thanks!

>>> Source/JavaScriptCore/create_hash_table:-337
>>> -        }
>> 
>> What about these?  I don't see the code that replaces them.
> 
> Oh, I think they were never needed in the first place.  Yusuke, can you confirm before landing?  Thanks.

Yes, this is dead code.
We no longer use lut table for ArrayPrototype.

[WebKit Commit Bot]

Comment on attachment 299935 [details]
Patch

Clearing flags on attachment: 299935

Committed r211306: <http://trac.webkit.org/changeset/211306>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.