Bug 167483 – [QuickLook] Make HTTP QuickLook tests work in Apple Internal DumpRenderTree

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Daniel Bates]

We should write the tests in LayoutTests/http/tests/quicklook/ in terms of LayoutTest/resources/ui-helpers.js so that they can run in an Apple Internal build of Legacy WebKit.

[Daniel Bates]

Created attachment 299897 [details]
Layout tests

[Andy Estes]

Comment on attachment 299897 [details]
Layout tests

View in context: https://bugs.webkit.org/attachment.cgi?id=299897&action=review

> LayoutTests/http/tests/quicklook/at-import-stylesheet-blocked.html:19
> +    // FIXME: For some reason the (x, y) coordinates of the hyperlink "Run test" is offset 2 pixels
> +    // in legacy WebKit (why?).
> +    var fudgeFactor = UIHelper.isWebKit2() ? 0 : 2;
> +    UIHelper.wait(UIHelper.activateAt(frame.offsetLeft + 5 + fudgeFactor, frame.offsetTop + 5 + fudgeFactor));

If this FIXME is ever addressed, you'll have to update 8 copies of this function. Can this be moved to a .js file?

[Daniel Bates]

(In reply to comment #2)
> Comment on attachment 299897 [details]
> Layout tests
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=299897&action=review
> 
> > LayoutTests/http/tests/quicklook/at-import-stylesheet-blocked.html:19
> > +    // FIXME: For some reason the (x, y) coordinates of the hyperlink "Run test" is offset 2 pixels
> > +    // in legacy WebKit (why?).
> > +    var fudgeFactor = UIHelper.isWebKit2() ? 0 : 2;
> > +    UIHelper.wait(UIHelper.activateAt(frame.offsetLeft + 5 + fudgeFactor, frame.offsetTop + 5 + fudgeFactor));
> 
> If this FIXME is ever addressed, you'll have to update 8 copies of this
> function. Can this be moved to a .js file?

Will move this function to a common file, LayoutTests/http/tests/quicklook/resources/tap-run-test-hyperlink.js, before landing.

[Daniel Bates]

Committed r211373: <http://trac.webkit.org/changeset/211373>