Bug 167471 – Fix CPU usage diagnostic logging in PerActivityStateCPUUsageSampler

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

Fix CPU usage diagnostic logging in PerActivityStateCPUUsageSampler to use numeric values for logDiagnosticMessageWithValue().

[Chris Dumez]

<rdar://problem/30221723>

[Chris Dumez]

Created attachment 299870 [details]
Patch

[Alex Christensen]

Comment on attachment 299870 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299870&action=review

> Source/WebKit2/UIProcess/PerActivityStateCPUUsageSampler.cpp:87
> +        page->logDiagnosticMessageWithValue(DiagnosticLoggingKeys::cpuUsageKey(), activityStateKey, String::number(cpuUsage, 1), false);

Yeah, we could just make logDiagnosticMessageWithValue take a double and call String::number.

[Chris Dumez]

Comment on attachment 299870 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299870&action=review

>> Source/WebKit2/UIProcess/PerActivityStateCPUUsageSampler.cpp:87
>> +        page->logDiagnosticMessageWithValue(DiagnosticLoggingKeys::cpuUsageKey(), activityStateKey, String::number(cpuUsage, 1), false);
> 
> Yeah, we could just make logDiagnosticMessageWithValue take a double and call String::number.

The number of significant digits we log matters though and may depend on the call sites. For example, here 1 significant digit is sufficient but you could imagine us wanting more (or less) in other places.

[Chris Dumez]

Comment on attachment 299870 [details]
Patch

Clearing flags on attachment: 299870

Committed r211239: <http://trac.webkit.org/changeset/211239>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.