Bug 167467 - QueueStatusServer should have an explicit timeout for _fetch_url
Summary: QueueStatusServer should have an explicit timeout for _fetch_url
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
Depends on:
Reported: 2017-01-26 14:03 PST by Aakash Jain
Modified: 2017-01-30 15:23 PST (History)
6 users (show)

See Also:

Proposed patch (1.27 KB, patch)
2017-01-26 14:08 PST, Aakash Jain
no flags Details | Formatted Diff | Diff
Updated patch (1.27 KB, patch)
2017-01-30 14:50 PST, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2017-01-26 14:03:06 PST
see rdar://problem/24792814
Comment 1 Aakash Jain 2017-01-26 14:08:06 PST
Created attachment 299848 [details]
Proposed patch
Comment 2 Alexey Proskuryakov 2017-01-27 13:52:52 PST
Comment on attachment 299848 [details]
Proposed patch

How long does this usually take? 15 seconds sounds short generally speaking, so I'd like to understand it better.
Comment 3 Aakash Jain 2017-01-30 13:43:46 PST
In the last hang, i noticed it took about 18s (from 22:10:31 to 22:10:49). We have only one data point right now (after the last time we added more logs).

I can increase this timeout to 60s or 120s, my concern is that we should have explicit timeout, in order to avoid possibility of timeout being infinite.
Comment 4 Alexey Proskuryakov 2017-01-30 14:41:50 PST
If this is just to avoid infinite timeout, would making it 5 minutes makes sense?
Comment 5 Aakash Jain 2017-01-30 14:50:05 PST
Created attachment 300146 [details]
Updated patch

Yes, 5 minutes makes sense. Updated the patch.
Comment 6 WebKit Commit Bot 2017-01-30 15:23:21 PST
Comment on attachment 300146 [details]
Updated patch

Clearing flags on attachment: 300146

Committed r211389: <http://trac.webkit.org/changeset/211389>
Comment 7 WebKit Commit Bot 2017-01-30 15:23:26 PST
All reviewed patches have been landed.  Closing bug.