Bug 167462 - EventTarget should visit the JSEventListeners using visitAdditionalChildren
Summary: EventTarget should visit the JSEventListeners using visitAdditionalChildren
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-01-26 12:49 PST by Filip Pizlo
Modified: 2017-01-27 09:32 PST (History)
11 users (show)

See Also:


Attachments
the patch (3.69 KB, patch)
2017-01-26 12:53 PST, Filip Pizlo
msaboff: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-elcapitan (565.52 KB, application/zip)
2017-01-26 13:44 PST, Build Bot
no flags Details
Archive of layout-test-results from ews112 for mac-elcapitan (550.73 KB, application/zip)
2017-01-26 13:49 PST, Build Bot
no flags Details
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (1.28 MB, application/zip)
2017-01-26 13:51 PST, Build Bot
no flags Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (deleted)
2017-01-26 14:12 PST, Build Bot
no flags Details
the patch (4.58 KB, patch)
2017-01-26 14:26 PST, Filip Pizlo
msaboff: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-elcapitan (1.00 MB, application/zip)
2017-01-26 15:29 PST, Build Bot
no flags Details
the patch (6.45 KB, patch)
2017-01-26 15:42 PST, Filip Pizlo
msaboff: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2017-01-26 12:49:16 PST
Patch forthcoming.
Comment 1 Filip Pizlo 2017-01-26 12:53:37 PST
Created attachment 299836 [details]
the patch
Comment 2 Radar WebKit Bug Importer 2017-01-26 12:53:54 PST
<rdar://problem/30216742>
Comment 3 Michael Saboff 2017-01-26 13:12:24 PST
Comment on attachment 299836 [details]
the patch

r=me
Comment 4 Build Bot 2017-01-26 13:44:15 PST
Comment on attachment 299836 [details]
the patch

Attachment 299836 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2954136

Number of test failures exceeded the failure limit.
Comment 5 Build Bot 2017-01-26 13:44:19 PST
Created attachment 299841 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 6 Build Bot 2017-01-26 13:49:50 PST
Comment on attachment 299836 [details]
the patch

Attachment 299836 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2954135

Number of test failures exceeded the failure limit.
Comment 7 Build Bot 2017-01-26 13:49:54 PST
Created attachment 299843 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 8 Build Bot 2017-01-26 13:51:20 PST
Comment on attachment 299836 [details]
the patch

Attachment 299836 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2954155

Number of test failures exceeded the failure limit.
Comment 9 Build Bot 2017-01-26 13:51:26 PST
Created attachment 299844 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 10 Build Bot 2017-01-26 14:12:41 PST
Comment on attachment 299836 [details]
the patch

Attachment 299836 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2954175

Number of test failures exceeded the failure limit.
Comment 11 Build Bot 2017-01-26 14:12:49 PST
Created attachment 299850 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 12 Filip Pizlo 2017-01-26 14:26:53 PST
Created attachment 299855 [details]
the patch
Comment 13 Michael Saboff 2017-01-26 14:34:58 PST
Comment on attachment 299855 [details]
the patch

r=me
Comment 14 Michael Saboff 2017-01-26 14:41:55 PST
Comment on attachment 299855 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299855&action=review

> Source/WebCore/bindings/js/JSDOMWindowCustom.cpp:56
> +    wrapped().visitJSEventListeners(visitor);

Add a comment why this is needed here.
Comment 15 Filip Pizlo 2017-01-26 15:23:17 PST
Looks like the timeouts the bots are seeing are real.
Comment 16 Build Bot 2017-01-26 15:29:30 PST
Comment on attachment 299855 [details]
the patch

Attachment 299855 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2954599

New failing tests:
inspector/worker/worker-create-and-terminate.html
inspector/worker/console-basic.html
fast/canvas/webgl/typed-arrays-in-workers.html
fast/workers/worker-messageport.html
fast/workers/worker-close.html
Comment 17 Build Bot 2017-01-26 15:29:35 PST
Created attachment 299864 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 18 Filip Pizlo 2017-01-26 15:42:35 PST
Created attachment 299866 [details]
the patch
Comment 19 Michael Saboff 2017-01-26 15:43:36 PST
Comment on attachment 299866 [details]
the patch

r=me
Comment 20 Filip Pizlo 2017-01-26 16:13:35 PST
Landed in https://trac.webkit.org/changeset/211238
Comment 22 Ryan Haddad 2017-01-27 09:32:20 PST
(In reply to comment #21)
> This broke bindings tests:
> https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK1%20%28Tests%29/
> builds/2735/steps/bindings-generation-tests/logs/stdio

I rebaselined the tests in https://trac.webkit.org/changeset/211285.