Bug 167449 – Remote Inspector: Listing should be updated when a target gains or loses a debugger session

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Summary:
Listing should be updated when a target gains or loses a debugger session

This controls whether or not we prevent device idle behavior or not.

So we should update the listing whenever a debugger session starts or ends.

Steps to Reproduce:
1. Remotely inspect a page in iOS Safari
2. Wait 2 minutes
  => device falls asleep, expected it to stay awake.

Notes:
Debuggers will want to track this state so different debuggers don't try to debug a target already being debugged.

[Joseph Pecoraro]

Created attachment 299793 [details]
[PATCH] Proposed Fix

[Radar WebKit Bug Importer]

<rdar://problem/30203156>

[Matt Baker]

Comment on attachment 299793 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=299793&action=review

> Source/JavaScriptCore/inspector/remote/RemoteInspector.mm:622
> +    auto target = m_targetMap.get(targetIdentifier);

I think we're preferring the more explicit auto* and auto& for pointer and reference types (per recent discussions with Darin).

[Blaze Burg]

Comment on attachment 299793 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=299793&action=review

r=me

> Source/JavaScriptCore/inspector/remote/RemoteInspector.mm:619
> +

This means caller must hold the listings lock before calling these, right?

[Joseph Pecoraro]

Comment on attachment 299793 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=299793&action=review

>> Source/JavaScriptCore/inspector/remote/RemoteInspector.mm:619
>> +
> 
> This means caller must hold the listings lock before calling these, right?

Yes

[WebKit Commit Bot]

Comment on attachment 299793 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 299793

Committed r211344: <http://trac.webkit.org/changeset/211344>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.