Bug 167448 – Improve W3C importer command line options

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[youenn fablet]

Importer command line options are confusing to newcomers.

[youenn fablet]

Created attachment 299792 [details]
Patch

[youenn fablet]

Patch transforms:
import-w3c-tests -t web-platform-tests/webrtc my-path-to-repository
into:
import-w3c-tests web-platform-tests/webrtc -s my-path-to-repository

[Joseph Pecoraro]

Comment on attachment 299792 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299792&action=review

> Tools/Scripts/webkitpy/w3c/test_importer.py:119
> -    parser = argparse.ArgumentParser(prog='import-w3c-tests [w3c_test_source_directory]')
> +    parser = argparse.ArgumentParser(prog='import-w3c-tests [web-platform-tests/test-suite-name...]')

More than anything, import-w3c-tests needs example commands. Otherwise I'm just going to forgot how to use it anyways.

A section of examples would go a long way! Thanks for improve this!

[Joseph Pecoraro]

Comment on attachment 299792 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299792&action=review

>> Tools/Scripts/webkitpy/w3c/test_importer.py:119
>> +    parser = argparse.ArgumentParser(prog='import-w3c-tests [web-platform-tests/test-suite-name...]')
> 
> More than anything, import-w3c-tests needs example commands. Otherwise I'm just going to forgot how to use it anyways.
> 
> A section of examples would go a long way! Thanks for improve this!

Err, I meant `import-w3c-tests --help` should have an examples section. Your previous bugzilla comment gives exactly what I would want to see in the help =)

[youenn fablet]

Created attachment 299808 [details]
Patch

[youenn fablet]

(In reply to comment #4)
> Comment on attachment 299792 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=299792&action=review
> 
> >> Tools/Scripts/webkitpy/w3c/test_importer.py:119
> >> +    parser = argparse.ArgumentParser(prog='import-w3c-tests [web-platform-tests/test-suite-name...]')
> > 
> > More than anything, import-w3c-tests needs example commands. Otherwise I'm just going to forgot how to use it anyways.
> > 
> > A section of examples would go a long way! Thanks for improve this!
> 
> Err, I meant `import-w3c-tests --help` should have an examples section. Your
> previous bugzilla comment gives exactly what I would want to see in the help
> =)

I added some examples.
I also made link conversion off by default and disabled git module generation since bots can no longer get them properly.

[youenn fablet]

Ping review

[Ryosuke Niwa]

Comment on attachment 299808 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299808&action=review

> Tools/Scripts/webkitpy/w3c/test_importer.py:128
> +    parser.add_argument('-l', '--links-conversion', dest='convert_test_harness_links', action='store_true', default=False,
> +       help='Change links (testharness js or css e.g.). This option only applies when providing a source directory. If this option is set, links are converted to point to WebKit testharness files. When tests are downloaded from W3C repository, links are converted for CSS tests and remain unchanged for WPT tests')

Given the webkit-dev discussion, we probably don't want to flip this default
but rather we should fix the link conversion so that it always works (probably in a separate patch).

[youenn fablet]

Created attachment 301017 [details]
Patch for landing

[youenn fablet]

(In reply to comment #8)
> Comment on attachment 299808 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=299808&action=review
> 
> > Tools/Scripts/webkitpy/w3c/test_importer.py:128
> > +    parser.add_argument('-l', '--links-conversion', dest='convert_test_harness_links', action='store_true', default=False,
> > +       help='Change links (testharness js or css e.g.). This option only applies when providing a source directory. If this option is set, links are converted to point to WebKit testharness files. When tests are downloaded from W3C repository, links are converted for CSS tests and remain unchanged for WPT tests')
> 
> Given the webkit-dev discussion, we probably don't want to flip this default
> but rather we should fix the link conversion so that it always works
> (probably in a separate patch).

I left the option unchanged for now.

[WebKit Commit Bot]

Comment on attachment 301017 [details]
Patch for landing

Clearing flags on attachment: 301017

Committed r211954: <http://trac.webkit.org/changeset/211954>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.