Bug 167422 - Commit queue fails to look at real name aliases for the reviewer
Summary: Commit queue fails to look at real name aliases for the reviewer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-25 09:43 PST by Simon Fraser (smfr)
Modified: 2017-01-30 17:21 PST (History)
6 users (show)

See Also:

Attachments
proposed fix (3.97 KB, patch)
2017-01-30 14:34 PST, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2017-01-25 09:43:11 PST 
https://bugs.webkit.org/show_bug.cgi?id=167223#c6

cq failed to find "Myles Maxfield" as an alias for "Myles C. Maxfield" even though that's in contributors.json:

   "Myles C. Maxfield" : {
      "aliases" : [
         "Myles Maxfield"
      ],
Comment 1 Alexey Proskuryakov 2017-01-30 14:34:50 PST 
Created attachment 300143 [details]
proposed fix
Comment 2 Joseph Pecoraro 2017-01-30 15:11:52 PST 
Comment on attachment 300143 [details]
proposed fix

r=me
Comment 3 WebKit Commit Bot 2017-01-30 17:21:47 PST 
Comment on attachment 300143 [details]
proposed fix

Clearing flags on attachment: 300143

Committed r211397: <http://trac.webkit.org/changeset/211397>
Comment 4 WebKit Commit Bot 2017-01-30 17:21:51 PST 
All reviewed patches have been landed.  Closing bug.