Bug 167401 - [iOS] Move WKPDFView's password view to WKWebView
Summary: [iOS] Move WKPDFView's password view to WKWebView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on: 167451
Blocks: 167407
  Show dependency tree / graph
 
Reported: 2017-01-24 18:21 PST by Andy Estes
Modified: 2017-07-27 13:56 PDT (History)
9 users (show)

See Also:

Attachments
Patch (16.08 KB, patch)
2017-01-24 19:03 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2017-01-24 18:21:46 PST 
[iOS] Move WKPDFView's password view to WKWebView
Comment 1 Andy Estes 2017-01-24 19:03:28 PST 
Created attachment 299663 [details]
Patch
Comment 2 WebKit Commit Bot 2017-01-25 12:49:59 PST 
Comment on attachment 299663 [details]
Patch

Clearing flags on attachment: 299663

Committed r211160: <http://trac.webkit.org/changeset/211160>
Comment 3 WebKit Commit Bot 2017-01-25 12:50:04 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Csaba Osztrogonác 2017-01-25 13:21:26 PST 
(In reply to comment #2)
> Comment on attachment 299663 [details]
> Patch
> 
> Clearing flags on attachment: 299663
> 
> Committed r211160: <http://trac.webkit.org/changeset/211160>

It broke the Apple Mac cmake build:

/Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:60:9: fatal error: 'WKPasswordView.h' file not found
#import "WKPasswordView.h"
        ^
1 error generated.
Comment 5 Radar WebKit Bug Importer 2017-07-27 13:56:15 PDT 
<rdar://problem/33575726>