Bug 167392 - REGRESSION(r210531): Relax same-volume display requirement for iOS
Summary: REGRESSION(r210531): Relax same-volume display requirement for iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified iOS 10
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-01-24 15:30 PST by Brent Fulgham
Modified: 2017-01-25 09:45 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.32 KB, patch)
2017-01-24 15:40 PST, Brent Fulgham
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (825.75 KB, application/zip)
2017-01-24 16:36 PST, Build Bot
no flags Details
Patch (4.01 KB, patch)
2017-01-24 16:53 PST, Brent Fulgham
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2017-01-24 15:30:32 PST
The changes in <https://trac.webkit.org/changeset/210531> cause problems on iOS, where applications often use local HTML files for parts of their user interface, which then access other content stored in a separate volume used for downloaded media.

This patch reverts this file volume check on the iOS Platform.
Comment 1 Brent Fulgham 2017-01-24 15:32:05 PST
<rdar://problem/30074665>
Comment 2 Brent Fulgham 2017-01-24 15:40:44 PST
Created attachment 299642 [details]
Patch
Comment 3 Build Bot 2017-01-24 16:36:05 PST
Comment on attachment 299642 [details]
Patch

Attachment 299642 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2943405

New failing tests:
fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html
storage/domstorage/sessionstorage/blocked-file-access.html
Comment 4 Build Bot 2017-01-24 16:36:08 PST
Created attachment 299652 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 5 Brent Fulgham 2017-01-24 16:53:10 PST
Created attachment 299654 [details]
Patch
Comment 6 WebKit Commit Bot 2017-01-24 17:44:03 PST
The commit-queue encountered the following flaky tests while processing attachment 299654 [details]:

imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location-protocol-setter-non-broken.html bug 167380 (author: youennf@gmail.com)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2017-01-24 17:44:38 PST
Comment on attachment 299654 [details]
Patch

Clearing flags on attachment: 299654

Committed r211125: <http://trac.webkit.org/changeset/211125>
Comment 8 WebKit Commit Bot 2017-01-24 17:44:42 PST
All reviewed patches have been landed.  Closing bug.
Comment 9 mitz 2017-01-24 19:41:33 PST
(In reply to comment #0)
> The changes in <https://trac.webkit.org/changeset/210531> cause problems on
> iOS, where applications often use local HTML files for parts of their user
> interface, which then access other content stored in a separate volume used
> for downloaded media.

Can the same changes cause problems on macOS whenever the user home directory is not on the same volume as /Applications?
Comment 10 Brent Fulgham 2017-01-25 09:45:53 PST
(In reply to comment #9)
> (In reply to comment #0)
> > The changes in <https://trac.webkit.org/changeset/210531> cause problems on
> > iOS, where applications often use local HTML files for parts of their user
> > interface, which then access other content stored in a separate volume used
> > for downloaded media.
> 
> Can the same changes cause problems on macOS whenever the user home
> directory is not on the same volume as /Applications?

I know of no such cases, but please file a radar if you are aware of one.