RESOLVED FIXED16739
XMLSerializer should reset default namespace when necessary 
https://bugs.webkit.org/show_bug.cgi?id=16739
Summary XMLSerializer should reset default namespace when necessary
Alexey Proskuryakov
Reported 2008-01-05 04:18:25 PST
When serializing an element with null namespace within an XHTML document, XMLSerializer should reset the namespace - currently, the result is as if the element were in XHTML namespace, too. Firefox 2 also has this problem.
Attachments
test case (564 bytes, application/xhtml+xml)
2008-01-05 04:19 PST, Alexey Proskuryakov 		no flags
Details
Patch (6.05 KB, patch)
2013-06-25 08:26 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (6.04 KB, patch)
2013-06-25 19:31 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (6.81 KB, patch)
2013-06-26 08:07 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (7.75 KB, patch)
2013-06-27 14:08 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (8.36 KB, patch)
2013-07-15 19:07 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (8.41 KB, patch)
2013-07-17 09:51 PDT, Rob Buis 		rniwa: review+
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2008-01-05 04:19:07 PST
Created attachment 18285 [details] test case
Rob Buis
Comment 2 2013-06-25 08:26:13 PDT
Created attachment 205404 [details] Patch
Rob Buis
Comment 3 2013-06-25 08:27:41 PDT
Comment on attachment 205404 [details] Patch This is based on bug 16496 patch which is not in yet, so clear the review flag for now.
Rob Buis
Comment 4 2013-06-25 19:31:28 PDT
Created attachment 205439 [details] Patch
Rob Buis
Comment 5 2013-06-26 08:07:38 PDT
Created attachment 205491 [details] Patch
Rob Buis
Comment 6 2013-06-27 14:08:32 PDT
Created attachment 205634 [details] Patch
Rob Buis
Comment 7 2013-06-27 14:10:10 PDT
Comment on attachment 205634 [details] Patch Clearing review flag because it builds on the patch in bug 16496. Compared to the previous patch this now includes the missing MarkupAccumulator.h change.
Rob Buis
Comment 8 2013-07-15 19:07:07 PDT
Created attachment 206717 [details] Patch
Rob Buis
Comment 9 2013-07-17 09:51:03 PDT
Created attachment 206894 [details] Patch
Ryosuke Niwa
Comment 10 2013-07-30 15:53:23 PDT
Comment on attachment 206894 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206894&action=review > Source/WebCore/editing/MarkupAccumulator.cpp:303 > + result.append(xmlnsAtom.string()); Maybe we should probably add a version of append that takes AtomicString. > Source/WebCore/editing/MarkupAccumulator.cpp:306 > + result.append('='); > + result.append('"'); > + result.append('"'); Why can't we just do result.appendLiteral("=\"\"");? > LayoutTests/fast/dom/XMLSerializer-element-empty-namespace-expected.txt:2 > +<div xmlns="http://www.w3.org/1999/xhtml" id="target"> <div id="output"> </div><a xmlns="" href="#"/></div> > + It'll be nice if the test had some description on what it's testing. > LayoutTests/fast/dom/XMLSerializer-element-empty-namespace2-expected.txt:1 > +<x xmlns="foo"><y xmlns=""/></x> Ditto.
Rob Buis
Comment 11 2013-07-30 18:59:45 PDT
Committed r153508: <http://trac.webkit.org/changeset/153508>
Lucas Forschler
Comment 12 2019-02-06 09:03:19 PST
Mass moving XML DOM bugs to the "DOM" Component.
Note You need to log in before you can comment on or make changes to this bug.