Bug 167386 - -0 is a valid array index and AtomicsObject should know this
Summary: -0 is a valid array index and AtomicsObject should know this
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
Keywords: InRadar
Depends on:
Reported: 2017-01-24 14:48 PST by Filip Pizlo
Modified: 2017-01-24 15:26 PST (History)
6 users (show)

See Also:

the patch (2.70 KB, patch)
2017-01-24 14:52 PST, Filip Pizlo
mark.lam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2017-01-24 14:48:14 PST
Patch forthcoming.
Comment 1 Radar WebKit Bug Importer 2017-01-24 14:50:23 PST
Comment 2 Filip Pizlo 2017-01-24 14:52:31 PST
Created attachment 299633 [details]
the patch
Comment 3 WebKit Commit Bot 2017-01-24 14:54:02 PST
Attachment 299633 [details] did not pass style-queue:

ERROR: Source/JavaScriptCore/runtime/AtomicsObject.cpp:113:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 4 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Mark Lam 2017-01-24 15:00:37 PST
Comment on attachment 299633 [details]
the patch

Comment 5 Filip Pizlo 2017-01-24 15:26:08 PST
Landed in https://trac.webkit.org/changeset/211113