Bug 167385 – [ios-simulator] API test WebKit2.WebsitePoliciesAutoplayEnabled timing out

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ryan Haddad]

[ios-simulator] API test WebKit2.WebsitePoliciesAutoplayEnabled timing out

https://build.webkit.org/builders/Apple%20iOS%2010%20Simulator%20Debug%20WK2%20%28Tests%29/builds/2891

[Ryan Haddad]

The test was added with https://trac.webkit.org/changeset/211097

[Matt Rajca]

The JS used timeouts in the HTML test files might just have to be increased from 100 ms. Is there a way to test this without making a commit? I don't think EWS runs API tests.

[Ryan Haddad]

(In reply to comment #2)
> The JS used timeouts in the HTML test files might just have to be increased
> from 100 ms. Is there a way to test this without making a commit? I don't
> think EWS runs API tests.

If you have a build for the simulator, you can run API tests locally with:

./Tools/Scripts/run-api-tests --verbose --ios-simulator

[Ryan Haddad]

> If you have a build for the simulator, you can run API tests locally with:
> 
> ./Tools/Scripts/run-api-tests --verbose --ios-simulator

Actually, make that:

./Tools/Scripts/run-api-tests --no-build --verbose --ios-simulator WebKit2.WebsitePoliciesAutoplayEnabled

[Alexey Proskuryakov]

This test expects "did-no-play" three times, so increasing the timeout would have quite  cost.

Isn't there a better way to detect the condition? Her would know for sure.

[Alexey Proskuryakov]

*Jer*!

[Jer Noble]

(In reply to comment #6)
> *Jer*!

Calling video.play() will now return a Promise, which will reject if playback is not allowed.  Seems like the test could use that rather than waiting to see if playback doesn't start.

[Matt Rajca]

Created attachment 299753 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 299753 [details]
Patch

Clearing flags on attachment: 299753

Committed r211174: <http://trac.webkit.org/changeset/211174>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.