Bug 167378 - Clean up Performance IDL interfaces so they are easier to read
Summary: Clean up Performance IDL interfaces so they are easier to read
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-24 12:18 PST by Joseph Pecoraro
Modified: 2017-01-24 13:46 PST (History)
6 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (8.29 KB, patch)
2017-01-24 12:24 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-01-24 12:18:33 PST 
Clean up Performance IDL interfaces so they are easier to read.

There are a ton of specs, and each thing is defined in its own spec. So link to each spec appropriately.

Also take this opportunity to use new typedefs and add an insignificant property.
Comment 1 Joseph Pecoraro 2017-01-24 12:24:20 PST 
Created attachment 299615 [details]
[PATCH] Proposed Fix
Comment 2 Chris Dumez 2017-01-24 13:02:05 PST 
Comment on attachment 299615 [details]
[PATCH] Proposed Fix

We should be using partial interfaces like in those specs :(
Comment 3 Joseph Pecoraro 2017-01-24 13:18:44 PST 
(In reply to comment #2)
> Comment on attachment 299615 [details]
> [PATCH] Proposed Fix
> 
> We should be using partial interfaces like in those specs :(

I'll get there eventually! This was really about getting the links updated so that I can make sense of all 5 or 6 specs involved...
Comment 4 WebKit Commit Bot 2017-01-24 13:45:58 PST 
The commit-queue encountered the following flaky tests while processing attachment 299615 [details]:

imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location-protocol-setter-non-broken.html bug 167380 (author: youennf@gmail.com)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2017-01-24 13:46:30 PST 
Comment on attachment 299615 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 299615

Committed r211109: <http://trac.webkit.org/changeset/211109>
Comment 6 WebKit Commit Bot 2017-01-24 13:46:35 PST 
All reviewed patches have been landed.  Closing bug.