Bug 167372 - LayoutTest media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles.html is a flaky failure
Summary: LayoutTest media/modern-media-controls/macos-fullscreen-media-controls/macos-...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-24 08:18 PST by Ryan Haddad
Modified: 2017-02-14 08:25 PST (History)
3 users (show)

See Also:


Attachments
Patch for landing (1.63 KB, patch)
2017-02-02 05:27 PST, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch for landing (1.63 KB, patch)
2017-02-02 05:29 PST, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch for landing (4.19 KB, patch)
2017-02-14 06:55 PST, Antoine Quint
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2017-01-24 08:18:04 PST
LayoutTest media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles.html is a flaky failure

https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r211078%20(11017)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmodern-media-controls%2Fmacos-fullscreen-media-controls%2Fmacos-fullscreen-media-controls-buttons-styles.html

--- /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles-expected.txt
+++ /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles-actual.txt
@@ -9,12 +9,12 @@
 PASS style.height is "44px"
 
 PlayPauseButton
-PASS style.left is "78px"
+FAIL style.left should be 78px. Was 54px.
 PASS style.webkitMaskPositionY is "12px"
 PASS style.height is "44px"
 
 ForwardButton
-PASS style.left is "127px"
+FAIL style.left should be 127px. Was 81px.
 PASS style.webkitMaskPositionY is "16px"
 PASS style.height is "44px"
 
@@ -24,17 +24,17 @@
 PASS style.height is "44px"
 
 PiPButton
-PASS style.left is "44px"
+FAIL style.left should be 44px. Was 28px.
 PASS style.webkitMaskPositionY is "13px"
 PASS style.height is "44px"
 
 TracksButton
-PASS style.left is "82px"
+FAIL style.left should be 82px. Was 44px.
 PASS style.webkitMaskPositionY is "15px"
 PASS style.height is "44px"
 
 FullscreenButton
-PASS style.left is "114px"
+FAIL style.left should be 114px. Was 60px.
 PASS style.webkitMaskPositionY is "13px"
 PASS style.height is "44px"
Comment 1 Ryan Haddad 2017-01-24 08:21:36 PST
This seems to be limited to macOS Debug WK1.
Comment 2 Ryan Haddad 2017-01-24 12:50:57 PST
Marked as flaky in https://trac.webkit.org/r211096
Comment 3 Jon Lee 2017-01-24 12:55:27 PST
Ryan said he was seeing this on EWS also.
Comment 4 Antoine Quint 2017-02-02 05:27:12 PST
Created attachment 300402 [details]
Patch for landing
Comment 5 Antoine Quint 2017-02-02 05:29:04 PST
Created attachment 300403 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2017-02-02 07:01:01 PST
Comment on attachment 300403 [details]
Patch for landing

Clearing flags on attachment: 300403

Committed r211558: <http://trac.webkit.org/changeset/211558>
Comment 7 WebKit Commit Bot 2017-02-02 07:01:05 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Ryan Haddad 2017-02-10 12:21:40 PST
Still flaky
Comment 9 Antoine Quint 2017-02-14 06:55:45 PST
Created attachment 301494 [details]
Patch for landing
Comment 10 WebKit Commit Bot 2017-02-14 08:24:57 PST
Comment on attachment 301494 [details]
Patch for landing

Clearing flags on attachment: 301494

Committed r212293: <http://trac.webkit.org/changeset/212293>
Comment 11 WebKit Commit Bot 2017-02-14 08:25:01 PST
All reviewed patches have been landed.  Closing bug.