WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
167368
VS2015 supports ref qualifiers
https://bugs.webkit.org/show_bug.cgi?id=167368
Summary
VS2015 supports ref qualifiers
Konstantin Tokarev
Reported
2017-01-24 02:38:57 PST
WTF_COMPILER_SUPPORTS_CXX_REFERENCE_QUALIFIED_FUNCTIONS should be defined for VS2015
Attachments
Patch
(1.09 KB, patch)
2017-01-24 02:41 PST
,
Konstantin Tokarev
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1
2017-01-24 02:41:34 PST
Created
attachment 299591
[details]
Patch
WebKit Commit Bot
Comment 2
2017-01-24 10:16:28 PST
Comment on
attachment 299591
[details]
Patch Clearing flags on attachment: 299591 Committed
r211088
: <
http://trac.webkit.org/changeset/211088
>
WebKit Commit Bot
Comment 3
2017-01-24 10:16:33 PST
All reviewed patches have been landed. Closing bug.
Alex Christensen
Comment 4
2017-01-24 11:54:24 PST
Comment on
attachment 299591
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=299591&action=review
> Source/WTF/wtf/Compiler.h:124 > +#if _MSC_VER >= 1900
We don't support Visual Studio versions older than CS2015. This shouldn't be necessary.
> Source/WTF/wtf/Compiler.h:130 > #if defined(_MSC_VER) && _MSC_VER < 1800
This should be updated instead.
Konstantin Tokarev
Comment 5
2017-01-24 11:57:06 PST
Comment on
attachment 299591
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=299591&action=review
>> Source/WTF/wtf/Compiler.h:124 >> +#if _MSC_VER >= 1900 > > We don't support Visual Studio versions older than CS2015. This shouldn't be necessary.
OK, I thought you may be using this file in some internal project
>> Source/WTF/wtf/Compiler.h:130 >> #if defined(_MSC_VER) && _MSC_VER < 1800 > > This should be updated instead.
Will do
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug